sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/pci_ops: Drop unused parameter

Browse Source 
Drop the bus parameter, we do not use it.

It would still be possible to do per-bus selection
by evaluating the bus number, but currently we do
not have need for that either.

Change-Id: I09e928b4677d9db2eee12730ba7b3fdd8837805c
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/31678
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Kyösti Mälkki
2019-01-23 15:56:30 +02:00
parent 92b5296a7b
commit 00ad8dfa18
6 changed files with 54 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/device/pci_ops.c
View File

@@ -70,41 +70,41 @@ static struct bus *get_pbus(struct device *dev)
u8 pci_read_config8(struct device *dev, unsigned int where)
{
struct bus *pbus = get_pbus(dev);
return pci_bus_ops(pbus, dev)->read8(pbus, dev->bus->secondary,
return pci_bus_ops(pbus, dev)->read8(dev->bus->secondary,
dev->path.pci.devfn, where);
}
u16 pci_read_config16(struct device *dev, unsigned int where)
{
struct bus *pbus = get_pbus(dev);
return pci_bus_ops(pbus, dev)->read16(pbus, dev->bus->secondary,
return pci_bus_ops(pbus, dev)->read16(dev->bus->secondary,
dev->path.pci.devfn, where);
}
u32 pci_read_config32(struct device *dev, unsigned int where)
{
struct bus *pbus = get_pbus(dev);
return pci_bus_ops(pbus, dev)->read32(pbus, dev->bus->secondary,
return pci_bus_ops(pbus, dev)->read32(dev->bus->secondary,
dev->path.pci.devfn, where);
}
void pci_write_config8(struct device *dev, unsigned int where, u8 val)
{
struct bus *pbus = get_pbus(dev);
pci_bus_ops(pbus, dev)->write8(pbus, dev->bus->secondary,
pci_bus_ops(pbus, dev)->write8(dev->bus->secondary,
dev->path.pci.devfn, where, val);
}
void pci_write_config16(struct device *dev, unsigned int where, u16 val)
{
struct bus *pbus = get_pbus(dev);
pci_bus_ops(pbus, dev)->write16(pbus, dev->bus->secondary,
pci_bus_ops(pbus, dev)->write16(dev->bus->secondary,
dev->path.pci.devfn, where, val);
}
void pci_write_config32(struct device *dev, unsigned int where, u32 val)
{
struct bus *pbus = get_pbus(dev);
pci_bus_ops(pbus, dev)->write32(pbus, dev->bus->secondary,
pci_bus_ops(pbus, dev)->write32(dev->bus->secondary,
dev->path.pci.devfn, where, val);
}

21
src/device/pci_ops_mmconf.c
View File

@@ -29,38 +29,35 @@
(((DEVFN) & 0xFF) << 12) |\
((WHERE) & 0xFFF)) & ~MASK))
static uint8_t pci_mmconf_read_config8(struct bus *pbus, int bus, int devfn,
int where)
static uint8_t pci_mmconf_read_config8(int bus, int devfn, int where)
{
return read8(PCI_MMIO_ADDR(bus, devfn, where, 0));
}
static uint16_t pci_mmconf_read_config16(struct bus *pbus, int bus, int devfn,
int where)
static uint16_t pci_mmconf_read_config16(int bus, int devfn, int where)
{
return read16(PCI_MMIO_ADDR(bus, devfn, where, 1));
}
static uint32_t pci_mmconf_read_config32(struct bus *pbus, int bus, int devfn,
int where)
static uint32_t pci_mmconf_read_config32(int bus, int devfn, int where)
{
return read32(PCI_MMIO_ADDR(bus, devfn, where, 3));
}
static void pci_mmconf_write_config8(struct bus *pbus, int bus, int devfn,
int where, uint8_t value)
static void pci_mmconf_write_config8(int bus, int devfn, int where,
uint8_t value)
{
write8(PCI_MMIO_ADDR(bus, devfn, where, 0), value);
}
static void pci_mmconf_write_config16(struct bus *pbus, int bus, int devfn,
int where, uint16_t value)
static void pci_mmconf_write_config16(int bus, int devfn, int where,
uint16_t value)
{
write16(PCI_MMIO_ADDR(bus, devfn, where, 1), value);
}
static void pci_mmconf_write_config32(struct bus *pbus, int bus, int devfn,
int where, uint32_t value)
static void pci_mmconf_write_config32(int bus, int devfn, int where,
uint32_t value)
{
write32(PCI_MMIO_ADDR(bus, devfn, where, 3), value);
}