From 02967e6113b40412ee430c429f4ac5f3c41da204 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Fri, 18 Feb 2022 13:22:25 +0100 Subject: [PATCH] soc/intel/alderlake: Fix function pointer type const void is not a proper return type for a function. It's the function pointer themselves that need to be const. This fixes building with clang. Change-Id: I99888ab9d9d80f1d6edb33b9f4a3f556f211a6e2 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/62178 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak --- src/soc/intel/alderlake/fsp_params.c | 2 +- src/soc/intel/alderlake/romstage/fsp_params.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 90e6ab25f5..dac36934df 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -799,7 +799,7 @@ static void soc_silicon_init_params(FSP_S_CONFIG *s_cfg, /* Override settings per board if required. */ mainboard_update_soc_chip_config(config); - const void (*fill_fsps_params[])(FSP_S_CONFIG *s_cfg, + void (*const fill_fsps_params[])(FSP_S_CONFIG *s_cfg, const struct soc_intel_alderlake_config *config) = { fill_fsps_lpss_params, fill_fsps_cpu_params, diff --git a/src/soc/intel/alderlake/romstage/fsp_params.c b/src/soc/intel/alderlake/romstage/fsp_params.c index b92a5da417..23e82651e3 100644 --- a/src/soc/intel/alderlake/romstage/fsp_params.c +++ b/src/soc/intel/alderlake/romstage/fsp_params.c @@ -330,7 +330,7 @@ static void fill_fspm_trace_params(FSP_M_CONFIG *m_cfg, static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, const struct soc_intel_alderlake_config *config) { - const void (*fill_fspm_params[])(FSP_M_CONFIG *m_cfg, + void (*const fill_fspm_params[])(FSP_M_CONFIG *m_cfg, const struct soc_intel_alderlake_config *config) = { fill_fspm_igd_params, fill_fspm_mrc_params,