sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/amd/pi/hudson/Kconfig: replace HUDSON_LEGACY_FREE option

Browse Source 
HUDSON_LEGACY_FREE controlled both if the legacy devices and the 8042
flags are set in the IA-PC boot architecture filed of the FADT. Since
some systems have legacy devices on the LPC bus, but no 8042-compatible
keyboard controller, replace this option with the two new options
HUDSON_FADT_LEGACY_DEVICES and HUDSON_FADT_8042.

TEST=The FACP table doesn't change on APU2

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Id4ff85630c90fb2ae8c8826bbc9049a08668210d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79893
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Felix Held
2024-01-10 21:54:22 +01:00
parent c0a4c895e9
commit 02d241245c
3 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/pcengines/apu2/Kconfig
View File

@@ -51,10 +51,6 @@ config ONBOARD_VGA_IS_PRIMARY
bool bool
default y default y
config HUDSON_LEGACY_FREE
bool
default y
config AGESA_BINARY_PI_FILE config AGESA_BINARY_PI_FILE
string string
default "3rdparty/blobs/mainboard/pcengines/apu2/AGESA.bin" default "3rdparty/blobs/mainboard/pcengines/apu2/AGESA.bin"

13
src/southbridge/amd/pi/hudson/Kconfig
View File

@@ -129,11 +129,16 @@ comment "AHCI7804"
comment "IDE to AHCI7804" comment "IDE to AHCI7804"
depends on HUDSON_SATA_MODE = 6 depends on HUDSON_SATA_MODE = 6
config HUDSON_LEGACY_FREE config HUDSON_FADT_LEGACY_DEVICES
bool "System is legacy free" bool
help help
Select y if there is no keyboard controller in the system. Select if there are legacy devices on the LPC bus.
This sets variables in AGESA and ACPI.
config HUDSON_FADT_8042
bool
help
Select if there is an 8042-compatible keyboard controller in the
system.
config AMDFW_OUTSIDE_CBFS config AMDFW_OUTSIDE_CBFS
def_bool n def_bool n

14
src/southbridge/amd/pi/hudson/fadt.c
View File

@@ -11,12 +11,6 @@
#include "hudson.h" #include "hudson.h"
#include "smi.h" #include "smi.h"
#if CONFIG(HUDSON_LEGACY_FREE)
#define FADT_BOOT_ARCH ACPI_FADT_LEGACY_FREE
#else
#define FADT_BOOT_ARCH (ACPI_FADT_LEGACY_DEVICES | ACPI_FADT_8042)
#endif
/* /*
* Reference section 5.2.9 Fixed ACPI Description Table (FADT) * Reference section 5.2.9 Fixed ACPI Description Table (FADT)
* in the ACPI 3.0b specification. * in the ACPI 3.0b specification.
@@ -40,7 +34,13 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
fadt->duty_offset = 1; /* CLK_VAL bits 3:1 */ fadt->duty_offset = 1; /* CLK_VAL bits 3:1 */
fadt->duty_width = 3; /* CLK_VAL bits 3:1 */ fadt->duty_width = 3; /* CLK_VAL bits 3:1 */
fadt->iapc_boot_arch = FADT_BOOT_ARCH; /* See table 5-10 */
fadt->iapc_boot_arch = ACPI_FADT_LEGACY_FREE; /* See table 5-10 */
if (CONFIG(HUDSON_FADT_LEGACY_DEVICES))
fadt->iapc_boot_arch |= ACPI_FADT_LEGACY_DEVICES;
if (CONFIG(HUDSON_FADT_8042))
fadt->iapc_boot_arch |= ACPI_FADT_8042;
fadt->res2 = 0; /* reserved, MUST be 0 ACPI 3.0 */ fadt->res2 = 0; /* reserved, MUST be 0 ACPI 3.0 */
fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-10 ACPI 3.0a spec */ fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-10 ACPI 3.0a spec */
ACPI_FADT_C1_SUPPORTED | ACPI_FADT_C1_SUPPORTED |