sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

complier.h: add __noreturn and use it in code base

Browse Source 
Add a __noreturn macro that wraps __attribute__((noreturn)) and replace
current users with the macro.

Change-Id: Iddd0728cf79678c3d1c1f7e7946c27375a644a7d
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/28505
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Aaron Durbin
2018-09-05 09:37:11 -06:00
committed by Patrick Georgi
parent 261d626669
commit 0370bcf40c
11 changed files with 25 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/reset.c
View File

@@ -19,7 +19,7 @@
#include <halt.h>
#include <reset.h>
__attribute__((noreturn)) static void __hard_reset(void) {
__noreturn static void __hard_reset(void) {
if (IS_ENABLED(CONFIG_HAVE_HARD_RESET))
do_hard_reset();
else

13
src/lib/ubsan.c
View File

@@ -43,8 +43,7 @@ typedef uintptr_t ubsan_value_handle_t;
*/
#pragma GCC diagnostic ignored "-Wmissing-prototypes"
__attribute__((noreturn))
static void ubsan_abort(const struct ubsan_source_location *location,
static void __noreturn ubsan_abort(const struct ubsan_source_location *location,
const char *violation) {
static const struct ubsan_source_location unknown_location = {
"<unknown file>",
@@ -61,8 +60,8 @@ static void ubsan_abort(const struct ubsan_source_location *location,
}
#define ABORT_VARIANT(name, params, call) \
__attribute__((noreturn)) void __ubsan_handle_##name##_abort params; \
__attribute__((noreturn)) void __ubsan_handle_##name##_abort params { \
__noreturn void __ubsan_handle_##name##_abort params; \
__noreturn void __ubsan_handle_##name##_abort params { \
__ubsan_handle_##name call; \
__builtin_unreachable(); \
}
@@ -212,16 +211,14 @@ struct ubsan_unreachable_data {
struct ubsan_source_location location;
};
__attribute__((noreturn))
void __ubsan_handle_builtin_unreachable(void *data_raw)
void __noreturn __ubsan_handle_builtin_unreachable(void *data_raw)
{
struct ubsan_unreachable_data *data =
(struct ubsan_unreachable_data *)data_raw;
ubsan_abort(&data->location, "reached unreachable");
}
__attribute__((noreturn))
void __ubsan_handle_missing_return(void *data_raw)
void __noreturn __ubsan_handle_missing_return(void *data_raw)
{
const struct ubsan_unreachable_data *data =
(struct ubsan_unreachable_data *)data_raw;