sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

{cpu,soc}: Use DEVICE_NOOP macro over dummy symbol

Browse Source 
Change-Id: Iaf2b2873bd1c52d7f936bd9b483e194a0872a626
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/7285
Tested-by: build bot (Jenkins)
Reviewed-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
This commit is contained in:
Edward O'Callaghan
2014-10-31 08:03:16 +11:00
parent 524625d4e0
commit 0625a8bcfb
8 changed files with 20 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/cpu/allwinner/a10/cpu.c
View File

@@ -25,13 +25,9 @@ static void cpu_init(struct device *dev)
/* TODO: Check if anything else needs to be explicitly initialized */
}
static void cpu_noop(struct device *dev)
{
}
static struct device_operations cpu_ops = {
.read_resources = cpu_noop,
.set_resources = cpu_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = cpu_enable_resources,
.init = cpu_init,
.scan_bus = NULL,

13
src/cpu/amd/sc520/sc520.c
View File

@@ -44,9 +44,6 @@ static void sc520_enable_resources(struct device *dev) {
pci_write_config8(dev, PCI_COMMAND, command);
command = pci_read_config8(dev, PCI_COMMAND);
printk(BIOS_SPEW, "========>%s, command 0x%x\n", __func__, command);
/*
*/
}
static void sc520_read_resources(device_t dev)
@@ -170,14 +167,10 @@ static void cpu_bus_init(device_t dev)
printk(BIOS_SPEW, "cpu_bus_init\n");
}
static void cpu_bus_noop(device_t dev)
{
}
static struct device_operations cpu_bus_ops = {
.read_resources = cpu_bus_noop,
.set_resources = cpu_bus_noop,
.enable_resources = cpu_bus_noop,
.read_resources = DEVICE_NOOP,
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = cpu_bus_init,
.scan_bus = 0,
};