sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

global: Refactor get_option usage

Browse Source 
Restructure get_option() calls to avoid unnecessary return value checks
by pre-assigning defaults to the options being retrieved.

Change-Id: I9159afe149a8eeed0785d1efd6eee8420b88b8f4
Signed-off-by: Varad Gautam <varadgautam@gmail.com>
Reviewed-on: http://review.coreboot.org/8631
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
This commit is contained in:
Varad Gautam
2015-03-11 09:54:41 +05:30
committed by Marc Jones
parent 015f0aea5d
commit 06ef046045
9 changed files with 38 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/cpu/amd/model_fxx/model_fxx_init.c
View File

@@ -250,9 +250,8 @@ static void init_ecc_memory(unsigned node_id)
}
/* See if we scrubbing should be enabled */
enable_scrubbing = 1;
if (get_option(&enable_scrubbing, "hw_scrubber") != CB_SUCCESS)
enable_scrubbing = CONFIG_HW_SCRUBBER;
enable_scrubbing = CONFIG_HW_SCRUBBER;
get_option(&enable_scrubbing, "hw_scrubber");
/* Enable cache scrubbing at the lowest possible rate */
if (enable_scrubbing) {