sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/ec: Drop __PRE_RAM__ and __SMM__ guards

Browse Source 
For files built in ramstage and smm -classes, testing
for !__PRE_RAM__ is redundant.

All chip_operations are exluded with use of DEVTREE_EARLY
in static devicetree, so garbage collection will take care
of the !__SMM__ cases.

Change-Id: Id7219848d6f5c41c4a9724a72204fa5ef9458e43
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34940
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Kyösti Mälkki
2019-08-17 15:14:38 +03:00
parent 7d640e2ac7
commit 07841c2a2a
9 changed files with 1 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/ec/quanta/ene_kb3940q/ec.c
View File

@@ -14,8 +14,6 @@
* GNU General Public License for more details.
*/
#ifndef __PRE_RAM__
#include <arch/io.h>
#include <console/console.h>
#include <device/device.h>
@@ -125,7 +123,6 @@ void ec_mem_write(u8 addr, u8 data)
return;
}
#ifndef __SMM__
static void ene_kb3940q_log_events(void)
{
#if CONFIG(ELOG)
@@ -165,5 +162,3 @@ struct chip_operations ec_quanta_ene_kb3940q_ops = {
CHIP_NAME("QUANTA EnE KB3940Q EC")
.enable_dev = enable_dev
};
#endif /* ! __SMM__ */
#endif /* ! __PRE_RAM__ */

4
src/ec/quanta/it8518/ec.c
View File

@@ -124,7 +124,6 @@ void ec_write(u16 addr, u8 data)
ec_write_ib(data);
}
#ifndef __PRE_RAM__
u8 ec_it8518_get_event(void)
{
@@ -149,7 +148,6 @@ void ec_it8518_enable_wake_events(void)
ec_write(EC_WAKE_SRC_ENABLE, reg8 | EC_LID_WAKE_ENABLE);
}
#ifndef __SMM__
static void it8518_init(struct device *dev)
{
if (!dev->enabled)
@@ -178,5 +176,3 @@ struct chip_operations ec_quanta_it8518_ops = {
CHIP_NAME("QUANTA IT8518 EC")
.enable_dev = enable_dev
};
#endif /* ! __SMM__ */
#endif /* ! __PRE_RAM__ */