sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

devicetree: Fix improper use of chip_operations

Browse Source 
Auto-discoverable PCI devices do not require field .enable_dev
of chip_operations to be set. They are matched with PCI drivers
by the use of PCI vendor and device ID fields.

The name given for the chip_operations struct must match the
pathname the way it is present in the devicetree.cb files. If
there was no match, util/sconfig would currently choose to
use the empty weak declaration it creates in static.c file.

Change-Id: I684a087a1f8ee4e1a5fd83450cd371fcfdbb6847
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35096
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Kyösti Mälkki
2019-08-25 13:05:46 +03:00
committed by Patrick Georgi
parent f2e1d0ae9a
commit 08c76e1f7d
6 changed files with 13 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/drivers/generic/bayhub/bh720.c
View File

@@ -82,12 +82,6 @@ static const struct pci_driver bayhub_bh720 __pci_driver = {
.devices = pci_device_ids,
};
static void bh720_enable(struct device *dev)
{
dev->ops = &bh720_ops;
}
struct chip_operations bayhub_bh720_ops = {
struct chip_operations drivers_generic_bayhub_ops = {
CHIP_NAME("BayHub Technology BH720 PCI to eMMC 5.0 HS200 bridge")
.enable_dev = bh720_enable,
};