security/tpm: remove tis_close()

This function was never called from outside of drivers and
src/drivers/pc80/tpm/tis.c was the only one doing it in a questionable
way.

tpm_vendor_cleanup() also isn't needed as one of tis_close() functions
was its only caller.

Change-Id: I9df76adfc21fca9fa1d1af7c40635ec0684ceb0f
Ticket: https://ticket.coreboot.org/issues/433
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68989
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
This commit is contained in:
Sergii Dmytruk
2022-10-29 16:57:07 +03:00
committed by Felix Held
parent 2393ad0bfb
commit 0a89d5237e
9 changed files with 15 additions and 115 deletions

View File

@@ -494,10 +494,6 @@ int tpm_vendor_init(struct tpm_chip *chip, unsigned int bus, uint32_t dev_addr)
return 0;
}
void tpm_vendor_cleanup(struct tpm_chip *chip)
{
}
enum cb_err tis_vendor_write(unsigned int addr, const void *buffer, size_t bytes)
{
return cr50_i2c_write(addr & 0xff, buffer, bytes) ? CB_ERR : CB_SUCCESS;

View File

@@ -39,16 +39,6 @@ int tis_open(void)
return 0;
}
int tis_close(void)
{
if (chip.is_open) {
tpm_vendor_cleanup(&chip);
chip.is_open = 0;
}
return 0;
}
int tis_init(void)
{
return tpm_vendor_probe(CONFIG_DRIVER_TPM_I2C_BUS,

View File

@@ -27,11 +27,6 @@ int tis_open(void)
return 0;
}
int tis_close(void)
{
return 0;
}
int tis_init(void)
{
return 0;

View File

@@ -550,8 +550,3 @@ out_err:
release_locality(chip, 0, 1);
return -1;
}
void tpm_vendor_cleanup(struct tpm_chip *chip)
{
release_locality(chip, chip->vendor.locality, 1);
}

View File

@@ -61,6 +61,4 @@ int tpm_vendor_probe(unsigned int bus, uint32_t addr);
int tpm_vendor_init(struct tpm_chip *chip, unsigned int bus, uint32_t dev_addr);
void tpm_vendor_cleanup(struct tpm_chip *chip);
#endif /* __DRIVERS_TPM_SLB9635_I2C_TPM_H__ */