sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drv/i2c/pi608gp: Fix style

Browse Source 
In commit e59f18bf29 ("drivers/i2c: Add PI7C9X2G608GP PCIe switch
driver (pi608gp)"), there were some suggestions after it's been already
merged.

This patch addresses the points regarding the code style and comments.

BUG=none
TEST=Build OK, no behavioral changes in the pi608gp driver, console logs
without changes.

Change-Id: I5fc54708e0085fea4bd1f2fbf2afb400d2ccbd46
Signed-off-by: Jan Samek <jan.samek@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75806
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Himanshu Sahdev <himanshu.sahdev@intel.com>
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Jan Samek
2023-06-12 10:51:39 +02:00
committed by Felix Held
parent 872e84fe30
commit 0acb78b21f
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/drivers/i2c/pi608gp/pi608gp.c
View File

@@ -102,7 +102,7 @@ pi608gp_reg_read(struct device *dev, uint8_t port, uint32_t reg_addr, uint32_t *
} }
/* Retrieve back the value from the received SMBus packet in big endian order. */ /* Retrieve back the value from the received SMBus packet in big endian order. */
*val = read_be32((void *) buf); *val = read_be32((void *)buf);
return CB_SUCCESS; return CB_SUCCESS;
} }
@@ -122,7 +122,7 @@ pi608gp_reg_write(struct device *dev, uint8_t port, uint32_t reg_addr, uint32_t
}; };
/* Insert register value to write in BE order after the header. */ /* Insert register value to write in BE order after the header. */
write_be32((void *) &buf[4], val); write_be32((void *)&buf[4], val);
/* Perform the register write */ /* Perform the register write */
ret = smbus_block_write(dev, PI608GP_CMD_BLK_WR, sizeof(buf), buf); ret = smbus_block_write(dev, PI608GP_CMD_BLK_WR, sizeof(buf), buf);
@@ -134,8 +134,9 @@ pi608gp_reg_write(struct device *dev, uint8_t port, uint32_t reg_addr, uint32_t
return CB_SUCCESS; return CB_SUCCESS;
} }
static enum cb_err pi608gp_reg_update(struct device *dev, uint8_t port, uint32_t reg_addr, static enum cb_err
uint32_t and_mask, uint32_t or_mask) pi608gp_reg_update(struct device *dev, uint8_t port, uint32_t reg_addr, uint32_t and_mask,
uint32_t or_mask)
{ {
uint32_t val; uint32_t val;
@@ -153,7 +154,7 @@ static enum cb_err pi608gp_reg_update(struct device *dev, uint8_t port, uint32_t
static void pi608gp_init(struct device *dev) static void pi608gp_init(struct device *dev)
{ {
const uint8_t port = 0; /* Only port 0 is being configured */ const uint8_t port = 0; /* Only the upstream port is being configured */
struct drivers_i2c_pi608gp_config *config = dev->chip_info; struct drivers_i2c_pi608gp_config *config = dev->chip_info;
uint8_t amp_lvl, deemph_lvl; uint8_t amp_lvl, deemph_lvl;