sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google/wilco: Fix ACPI EC RAM read/write ops

Browse Source 
While debugging lack of battery status under Windows, it was discovered
that the read/write flags in the args to the EC RAM 'ECRW' method were
not being correctly identified. Force set them from the R() and W()
methods which call ECRW() so those calls are processed properly.

TEST=build/boot Windows on google/drallion, verify battery status,
charging, etc are all reported properly.

Change-Id: I2a40b8d50ba65213813c781e53b56cc1a8b8debf
Signed-off-by: Coolstar <coolstarorganization@gmail.com>
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72472
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Matt DeVillier
2023-01-25 14:27:24 -06:00
committed by Martin L Roth
parent 095043fcca
commit 0ace876a74
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/ec/google/wilco/acpi/ec.asl
View File

@@ -1,5 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
Name (RD, 0)
Name (WR, 1)
Device (EC0) Device (EC0)
{ {
Name (_HID, EisaId ("PNP0C09")) Name (_HID, EisaId ("PNP0C09"))
@@ -124,6 +127,8 @@ Device (EC0)
*/ */
Method (R, 1, Serialized, 2) Method (R, 1, Serialized, 2)
{ {
/* Set read operation */
Arg0[2] = RD
Return (ECRW (Arg0, 0)) Return (ECRW (Arg0, 0))
} }
@@ -134,6 +139,8 @@ Device (EC0)
*/ */
Method (W, 2, Serialized, 2) Method (W, 2, Serialized, 2)
{ {
/* Set write operation */
Arg0[2] = WR
Return (ECRW (Arg0, Arg1)) Return (ECRW (Arg0, Arg1))
} }

3
src/ec/google/wilco/acpi/ec_ram.asl
View File

@@ -1,8 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */ /* SPDX-License-Identifier: GPL-2.0-only */
Name (RD, 0)
Name (WR, 1)
/* /*
* EC RAM READ * EC RAM READ
*/ */