sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

arch/x86: Fix most of remaining issues detected by checkpatch

Browse Source 
Fix the following errors and warnings detected by checkpatch.pl:

ERROR: do not use assignment in if condition
ERROR: trailing statements should be on next line
ERROR: Macros with complex values should be enclosed in parentheses
ERROR: switch and case should be at the same indent
WARNING: char * array declaration might be better as static const
WARNING: else is not generally useful after a break or return
WARNING: storage class should be at the beginning of the declaration
WARNING: void function return statements are not generally useful
WARNING: break is not useful after a goto or return
WARNING: Single statement macros should not use a do {} while (0) loop
WARNING: sizeof *t should be sizeof(*t)
WARNING: Comparisons should place the constant on the right side of the test

TEST=Build and run on Galileo Gen2

Change-Id: I39d49790c5eaeedec5051e1fab0b1279275f6e7f
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18865
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Lee Leahy
2017-03-16 16:01:40 -07:00
parent 41dded3548
commit 0b5678f21f
18 changed files with 112 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/arch/x86/cpu.c
View File

@@ -118,7 +118,7 @@ static struct {
{ X86_VENDOR_SIS, "SiS SiS SiS ", },
};
static const char *x86_vendor_name[] = {
static const char * const x86_vendor_name[] = {
[X86_VENDOR_INTEL] = "Intel",
[X86_VENDOR_CYRIX] = "Cyrix",
[X86_VENDOR_AMD] = "AMD",
@@ -209,7 +209,7 @@ struct cpu_driver *find_cpu_driver(struct device *cpu)
if ((cpu->vendor == id->vendor) &&
(cpu->device == id->device))
return driver;
if (X86_VENDOR_ANY == id->vendor)
if (id->vendor == X86_VENDOR_ANY)
return driver;
}
}
@@ -264,7 +264,8 @@ void cpu_initialize(unsigned int index)
cpu->device -= c.x86_mask;
set_cpu_ops(cpu);
cpu->device += c.x86_mask;
if (!cpu->ops) die("Unknown cpu");
if (!cpu->ops)
die("Unknown cpu");
printk(BIOS_DEBUG, "Using generic CPU ops (good)\n");
}
@@ -278,8 +279,6 @@ void cpu_initialize(unsigned int index)
post_log_clear();
printk(BIOS_INFO, "CPU #%d initialized\n", index);
return;
}
void lb_arch_add_records(struct lb_header *header)