sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso: Add display identification and vbios name

Browse Source 
Add Picasso's Device ID and default filename.

Only a single Device ID is documented for Picasso so remove the oprom
remapper function.

Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Change-Id: Iaf43d7c8da41beb05b58c494f0a6814f8f571b18
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34422
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Marshall Dawson
2019-07-09 18:19:05 -05:00
committed by Martin Roth
parent ecd36ce759
commit 0d441daef6
3 changed files with 3 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/picasso/Kconfig
View File

@@ -111,14 +111,14 @@ config MMCONF_BUS_NUMBER
config VGA_BIOS_ID config VGA_BIOS_ID
string string
default "1002,98e4" default "1002,15d8"
help help
The default VGA BIOS PCI vendor/device ID should be set to the The default VGA BIOS PCI vendor/device ID should be set to the
result of the map_oprom_vendev() function in northbridge.c. result of the map_oprom_vendev() function in northbridge.c.
config VGA_BIOS_FILE config VGA_BIOS_FILE
string string
default "3rdparty/blobs/soc/amd/picasso/VBIOS.bin" default "3rdparty/blobs/soc/amd/picasso/PicassoGenericVbios.bin"
config S3_VGA_ROM_RUN config S3_VGA_ROM_RUN
bool bool

2
src/soc/amd/picasso/include/soc/pci_devs.h
View File

@@ -42,7 +42,7 @@
/* Internal Graphics */ /* Internal Graphics */
#define GFX_DEV 0x1 #define GFX_DEV 0x1
#define GFX_FUNC 0 #define GFX_FUNC 0
#define GFX_DEVID 0x98e4 /* subject to SKU/OPN variation */ #define GFX_DEVID 0x15d8
#define GFX_DEVFN PCI_DEVFN(GFX_DEV, GFX_FUNC) #define GFX_DEVFN PCI_DEVFN(GFX_DEV, GFX_FUNC)
#define SOC_GFX_DEV _SOC_DEV(GFX_DEV, GFX_FUNC) #define SOC_GFX_DEV _SOC_DEV(GFX_DEV, GFX_FUNC)

17
src/soc/amd/picasso/northbridge.c
View File

@@ -310,20 +310,3 @@ void domain_set_resources(struct device *dev)
assign_resources(dev->link_list); assign_resources(dev->link_list);
} }
/*********************************************************************
* Change the vendor / device IDs to match the generic VBIOS header. *
*********************************************************************/
u32 map_oprom_vendev(u32 vendev)
{
u32 new_vendev;
new_vendev =
((vendev >= 0x100298e0) && (vendev <= 0x100298ef)) ?
0x100298e0 : vendev;
if (vendev != new_vendev)
printk(BIOS_NOTICE, "Mapping PCI device %8x to %8x\n",
vendev, new_vendev);
return new_vendev;
}