sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/ioapic: DEVICE_NOOP some stub function callbacks

Browse Source 
Just when you thought you found them all..
Reduces loc and makes NOP's explicit.

Change-Id: I416e0468b7f2f462c940daae695d67fb409aa4c6
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/7350
Tested-by: build bot (Jenkins)
Reviewed-by: Marc Jones <marc.jones@se-eng.com>
This commit is contained in:
Edward O'Callaghan
2014-11-07 12:43:49 +11:00
parent 2014111786
commit 0d84a2c03e
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/drivers/generic/ioapic/ioapic.c
View File

@ -20,6 +20,7 @@ static void ioapic_init(struct device *dev)
u32 i, ioapic_interrupts; u32 i, ioapic_interrupts;
u32 ioapic_base; u32 ioapic_base;
u8 ioapic_id; u8 ioapic_id;
if (!dev->enabled || !config) if (!dev->enabled || !config)
return; return;
@ -86,14 +87,6 @@ static void ioapic_init(struct device *dev)
} }
} }
static void ioapic_enable_resources(struct device *dev)
{
}
static void ioapic_nop(struct device *dummy)
{
}
static void ioapic_read_resources(struct device *dev) static void ioapic_read_resources(struct device *dev)
{ {
struct drivers_generic_ioapic_config *config = (struct drivers_generic_ioapic_config *)dev->chip_info; struct drivers_generic_ioapic_config *config = (struct drivers_generic_ioapic_config *)dev->chip_info;
@ -106,10 +99,10 @@ static void ioapic_read_resources(struct device *dev)
} }
static struct device_operations ioapic_operations = { static struct device_operations ioapic_operations = {
.read_resources = ioapic_read_resources, .read_resources = ioapic_read_resources,
.set_resources = ioapic_nop, .set_resources = DEVICE_NOOP,
.enable_resources = ioapic_enable_resources, .enable_resources = DEVICE_NOOP,
.init = ioapic_init, .init = ioapic_init,
}; };
static void enable_dev(struct device *dev) static void enable_dev(struct device *dev)