sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

southbridge/intel/lynxpoint: Fix undefined behavior

Browse Source 
Fix reports found by undefined behavior sanitizer. Left shifting an int
where the right operand is >= the width of the type is undefined. Add
UL suffix since it's safe for unsigned types.

Change-Id: I755b3c80a8d1b6cb6b6e5f411c6691e5dd17c266
Signed-off-by: Ryan Salsamendi <rsalsamendi@hotmail.com>
Reviewed-on: https://review.coreboot.org/20443
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Ryan Salsamendi
2017-06-30 17:15:57 -07:00
committed by Martin Roth
parent 0c731b512a
commit 0d9b360b42
7 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/southbridge/intel/lynxpoint/pcie.c
View File

@@ -608,7 +608,7 @@ static void pch_pcie_early(struct device *dev)
pci_update_config32(dev, 0x64, ~(1 << 11), (1 << 11));
pci_update_config32(dev, 0x68, ~(1 << 10), (1 << 10));
pci_update_config32(dev, 0x318, ~(0xffff << 16), (0x1414 << 16));
pci_update_config32(dev, 0x318, ~(0xffffUL << 16), (0x1414UL << 16));
/* Set L1 exit latency in LCAP register. */
if (!do_aspm && (pci_read_config8(dev, 0xf5) & 0x1))