sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/getac/p470: Null-terminate ec_id string buffer

Browse Source 
The EC ID of the ECDT needs to be null-terminated (see ACPI specification,
section 5.2.15), which currently isn't being done due to an off-by-one
error. strncpy() is bug-prone exactly because of issues like this, so just
skip it entirely and use memcpy() instead.

Change-Id: I0b62e1f32177c9768fa978053ab26bca93d7248d
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1402104
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34374
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
This commit is contained in:
Jacob Garber
2019-07-16 15:48:28 -06:00
committed by Patrick Georgi
parent d552acac1d
commit 0db6e7569d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/getac/p470/acpi_tables.c
View File

@@ -70,7 +70,7 @@ static long acpi_create_ecdt(acpi_ecdt_t * ecdt)
ecdt->gpe_bit = 23; // SCI interrupt within GPEx_STS ecdt->gpe_bit = 23; // SCI interrupt within GPEx_STS
strncpy((char *)ecdt->ec_id, ec_id, strlen(ec_id)); memcpy(ecdt->ec_id, ec_id, sizeof(ec_id));
header->checksum = header->checksum =
acpi_checksum((void *) ecdt, ecdt_len); acpi_checksum((void *) ecdt, ecdt_len);