sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

spi: Fix parameter types for spi functions

Browse Source 
1. Use size_t instead of unsigned int for bytes_out and bytes_in.
2. Use const attribute for spi_slave structure passed into xfer, claim
bus and release bus functions.

BUG=chrome-os-partner:59832
BRANCH=None
TEST=Compiles successfully

Change-Id: Ie70b3520b51c42d750f907892545510c6058f85a
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://review.coreboot.org/17682
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Furquan Shaikh
2016-11-30 04:34:22 -08:00
committed by Furquan Shaikh
parent 52896c6c33
commit 0dba0254ea
29 changed files with 148 additions and 149 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/drivers/spi/spi_flash.c
View File

@@ -48,8 +48,8 @@ static void spi_flash_addr(u32 addr, u8 *cmd)
* FIXME: This really should be abstracted better, but that will
* require overhauling the entire SPI infrastructure.
*/
static int do_spi_flash_cmd(struct spi_slave *spi, const void *dout,
unsigned int bytes_out, void *din, unsigned int bytes_in)
static int do_spi_flash_cmd(const struct spi_slave *spi, const void *dout,
size_t bytes_out, void *din, size_t bytes_in)
{
int ret = 1;

10
src/drivers/spi/tpm/tpm.c
View File

@@ -37,11 +37,11 @@
/* SPI Interface descriptor used by the driver. */
struct tpm_spi_if {
struct spi_slave *slave;
int (*cs_assert)(struct spi_slave *slave);
void (*cs_deassert)(struct spi_slave *slave);
int (*xfer)(struct spi_slave *slave, const void *dout,
unsigned bytesout, void *din,
unsigned bytesin);
int (*cs_assert)(const struct spi_slave *slave);
void (*cs_deassert)(const struct spi_slave *slave);
int (*xfer)(const struct spi_slave *slave, const void *dout,
size_t bytesout, void *din,
size_t bytesin);
};
/* Use the common SPI driver wrapper as the interface callbacks. */