sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86/mp_init: remove unused callback arguments

Browse Source 
The BSP and AP callback declarations both had an optional argument
that could be passed. In practice that functionality was never used
so drop it.

Change-Id: I47fa814a593b6c2ee164c88d255178d3fb71e8ce
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/14556
Tested-by: build bot (Jenkins)
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Leroy P Leahy <leroy.p.leahy@intel.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Aaron Durbin
2016-04-29 23:15:12 -05:00
parent ddf4fa0cc3
commit 0e55632661
10 changed files with 55 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/cpu/intel/haswell/haswell_init.c
View File

@@ -772,7 +772,7 @@ static int adjust_apic_id_ht_disabled(int index, int apic_id)
return 2 * index;
}
static void relocate_and_load_microcode(void *unused)
static void relocate_and_load_microcode(void)
{
/* Relocate the SMM handler. */
smm_relocate();
@@ -781,7 +781,7 @@ static void relocate_and_load_microcode(void *unused)
intel_microcode_load_unlocked(microcode_patch);
}
static void enable_smis(void *unused)
static void enable_smis(void)
{
/* Now that all APs have been relocated as well as the BSP let SMIs
* start flowing. */
@@ -792,11 +792,11 @@ static void enable_smis(void *unused)
}
static struct mp_flight_record mp_steps[] = {
MP_FR_NOBLOCK_APS(relocate_and_load_microcode, NULL,
relocate_and_load_microcode, NULL),
MP_FR_BLOCK_APS(mp_initialize_cpu, NULL, mp_initialize_cpu, NULL),
MP_FR_NOBLOCK_APS(relocate_and_load_microcode,
relocate_and_load_microcode),
MP_FR_BLOCK_APS(mp_initialize_cpu, mp_initialize_cpu),
/* Wait for APs to finish initialization before proceeding. */
MP_FR_BLOCK_APS(NULL, NULL, enable_smis, NULL),
MP_FR_BLOCK_APS(NULL, enable_smis),
};
void bsp_init_and_start_aps(struct bus *cpu_bus)

6
src/cpu/x86/mp_init.c
View File

@@ -129,7 +129,7 @@ static void ap_do_flight_plan(void)
barrier_wait(&rec->barrier);
if (rec->ap_call != NULL) {
rec->ap_call(rec->ap_arg);
rec->ap_call();
}
}
}
@@ -477,7 +477,7 @@ static int bsp_do_flight_plan(struct mp_params *mp_params)
}
if (rec->bsp_call != NULL) {
rec->bsp_call(rec->bsp_arg);
rec->bsp_call();
}
release_barrier(&rec->barrier);
@@ -563,7 +563,7 @@ int mp_init(struct bus *cpu_bus, struct mp_params *p)
return bsp_do_flight_plan(p);
}
void mp_initialize_cpu(void *unused)
void mp_initialize_cpu(void)
{
/* Call back into driver infrastructure for the AP initialization. */
struct cpu_info *info = cpu_info();