mc146818rtc: Remove the hyphen to build on NetBSD and Darwin
http://netbsd.gw.com/cgi-bin/man-cgi?date++NetBSD-current The NetBSD manual tells us the date in NetBSD doesn't take any flags to enable or disable padding in the format. By default, date pads numeric fields with zeroes. This will convert the number to octal one. So add "0x" to convert it to BCD directly. Change-Id: Icd44312acf01b8232f1da1fbaa70630d09007b40 Signed-off-by: Zheng Bao <zheng.bao@amd.com> Signed-off-by: zbao <fishbaozi@gmail.com> Reviewed-on: http://review.coreboot.org/1804 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Anton Kochkov <anton.kochkov@gmail.com>
This commit is contained in:
@@ -87,10 +87,10 @@ static void rtc_update_cmos_date(u8 has_century)
|
||||
cmos_write(0, RTC_CLK_SECOND);
|
||||
cmos_write(0, RTC_CLK_MINUTE);
|
||||
cmos_write(1, RTC_CLK_HOUR);
|
||||
cmos_write(RTC_TO_BCD(COREBOOT_BUILD_WEEKDAY) + 1, RTC_CLK_DAYOFWEEK);
|
||||
cmos_write(RTC_TO_BCD(COREBOOT_BUILD_DAY), RTC_CLK_DAYOFMONTH);
|
||||
cmos_write(RTC_TO_BCD(COREBOOT_BUILD_MONTH), RTC_CLK_MINUTE);
|
||||
cmos_write(RTC_TO_BCD(COREBOOT_BUILD_YEAR), RTC_CLK_YEAR);
|
||||
cmos_write(COREBOOT_BUILD_WEEKDAY_BCD + 1, RTC_CLK_DAYOFWEEK);
|
||||
cmos_write(COREBOOT_BUILD_DAY_BCD, RTC_CLK_DAYOFMONTH);
|
||||
cmos_write(COREBOOT_BUILD_MONTH_BCD, RTC_CLK_MINUTE);
|
||||
cmos_write(COREBOOT_BUILD_YEAR_BCD, RTC_CLK_YEAR);
|
||||
if (has_century) cmos_write(0x20, RTC_CLK_ALTCENTURY);
|
||||
}
|
||||
|
||||
|
@@ -63,8 +63,6 @@
|
||||
# define RTC_24H 0x02 /* 24 hour mode - else hours bit 7 means pm */
|
||||
# define RTC_DST_EN 0x01 /* auto switch DST - works f. USA only */
|
||||
|
||||
#define RTC_TO_BCD(value) (((value / 10) << 4) | (value % 10))
|
||||
|
||||
/**********************************************************************/
|
||||
#define RTC_INTR_FLAGS RTC_REG_C
|
||||
/* caution - cleared by read */
|
||||
|
Reference in New Issue
Block a user