sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device: Constify struct device * parameter to write_acpi_tables

Browse Source 
.write_acpi_tables() should not be updating the device structure. This
change makes the struct device * argument to it as const.

Change-Id: I50d013e83a404e0a0e3837ca16fa75c7eaa0e14a
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40701
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Furquan Shaikh
2020-04-24 06:41:18 -07:00
parent f939df7a95
commit 0f007d8ceb
75 changed files with 95 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/arch/x86/acpi.c
View File

@@ -758,9 +758,9 @@ void acpi_create_hpet(acpi_hpet_t *hpet)
header->checksum = acpi_checksum((void *)hpet, sizeof(acpi_hpet_t));
}
void acpi_create_vfct(struct device *device,
void acpi_create_vfct(const struct device *device,
acpi_vfct_t *vfct,
unsigned long (*acpi_fill_vfct)(struct device *device,
unsigned long (*acpi_fill_vfct)(const struct device *device,
acpi_vfct_t *vfct_struct, unsigned long current))
{
acpi_header_t *header = &(vfct->header);
@@ -791,7 +791,7 @@ void acpi_create_vfct(struct device *device,
header->checksum = acpi_checksum((void *)vfct, header->length);
}
void acpi_create_ipmi(struct device *device,
void acpi_create_ipmi(const struct device *device,
struct acpi_spmi *spmi,
const u16 ipmi_revision,
const acpi_addr_t *addr,
@@ -871,7 +871,7 @@ void acpi_create_ivrs(acpi_ivrs_t *ivrs,
header->checksum = acpi_checksum((void *)ivrs, header->length);
}
unsigned long acpi_write_hpet(struct device *device, unsigned long current,
unsigned long acpi_write_hpet(const struct device *device, unsigned long current,
acpi_rsdp_t *rsdp)
{
acpi_hpet_t *hpet;

8
src/arch/x86/include/arch/acpi.h
View File

@@ -906,13 +906,13 @@ void acpi_create_srat(acpi_srat_t *srat,
void acpi_create_slit(acpi_slit_t *slit,
unsigned long (*acpi_fill_slit)(unsigned long current));
void acpi_create_vfct(struct device *device,
void acpi_create_vfct(const struct device *device,
acpi_vfct_t *vfct,
unsigned long (*acpi_fill_vfct)(struct device *device,
unsigned long (*acpi_fill_vfct)(const struct device *device,
acpi_vfct_t *vfct_struct,
unsigned long current));
void acpi_create_ipmi(struct device *device,
void acpi_create_ipmi(const struct device *device,
struct acpi_spmi *spmi,
const u16 ipmi_revision,
const acpi_addr_t *addr,
@@ -926,7 +926,7 @@ void acpi_create_ivrs(acpi_ivrs_t *ivrs,
unsigned long current));
void acpi_create_hpet(acpi_hpet_t *hpet);
unsigned long acpi_write_hpet(struct device *device, unsigned long start,
unsigned long acpi_write_hpet(const struct device *device, unsigned long start,
acpi_rsdp_t *rsdp);
/* cpu/intel/speedstep/acpi.c */