sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CBFS: use cbfs_get_file_content whenever possible rather than cbfs_get_file

Browse Source 
Number one reason to use cbfs_get_file was to get file length.
With previous patch no more need for this.

Change-Id: I330dda914d800c991757c5967b11963276ba9e00
Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-on: http://review.coreboot.org/4674
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Tested-by: build bot (Jenkins)
This commit is contained in:
Vladimir Serbinenko
2014-01-12 14:12:15 +01:00
parent 0af61b6c82
commit 1287416822
13 changed files with 73 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/mainboard/gizmosphere/gizmo/BiosCallOuts.c
View File

@@ -444,16 +444,18 @@ AGESA_STATUS BiosReadSpd (UINT32 Func, UINT32 Data, VOID *ConfigPtr)
if (info->DimmId != 0)
return AGESA_UNSUPPORTED;
struct cbfs_file *spd_file;
char *spd_file;
size_t spd_file_len;
printk(BIOS_DEBUG, "read SPD\n");
spd_file = cbfs_get_file(CBFS_DEFAULT_MEDIA, "spd.bin");
spd_file = cbfs_get_file_content(CBFS_DEFAULT_MEDIA, "spd.bin", 0xab,
&spd_file_len);
if (!spd_file)
die("file [spd.bin] not found in CBFS");
if (spd_file->len < SPD_SIZE)
if (spd_file_len < SPD_SIZE)
die("Missing SPD data.");
memcpy((char*)info->Buffer, (char*)CBFS_SUBHEADER(spd_file), SPD_SIZE);
memcpy((char*)info->Buffer, spd_file, SPD_SIZE);
u16 crc = spd_ddr3_calc_crc(info->Buffer, SPD_SIZE);