sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

haswell: remove GPIO60 memory reset gate on S3 transition

Browse Source 
This is no longer tied to a GPIO but has a proper chipset pin.

Change-Id: Iba70338e8c67e3c3c1cb32e69bfea1282fda8cb5
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: http://review.coreboot.org/2643
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Duncan Laurie
2012-12-12 09:22:34 -08:00
committed by Ronald G. Minnich
parent 89f79a019f
commit 138f2cede4
1 changed files with 0 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/southbridge/intel/lynxpoint/smihandler.c
View File

@@ -290,41 +290,6 @@ static void busmaster_disable_on_bus(int bus)
} }
} }
/*
* Drive GPIO 60 low to gate memory reset in S3.
*
* Intel reference designs all use GPIO 60 but it is
* not a requirement and boards could use a different pin.
*/
static void southbridge_gate_memory_reset(void)
{
u32 reg32;
u16 gpiobase;
gpiobase = pci_read_config16(PCI_DEV(0, 0x1f, 0), GPIOBASE) & 0xfffc;
if (!gpiobase)
return;
/* Make sure it is set as GPIO */
reg32 = inl(gpiobase + GPIO_USE_SEL2);
if (!(reg32 & (1 << 28))) {
reg32 |= (1 << 28);
outl(reg32, gpiobase + GPIO_USE_SEL2);
}
/* Make sure it is set as output */
reg32 = inl(gpiobase + GP_IO_SEL2);
if (reg32 & (1 << 28)) {
reg32 &= ~(1 << 28);
outl(reg32, gpiobase + GP_IO_SEL2);
}
/* Drive the output low */
reg32 = inl(gpiobase + GP_LVL2);
reg32 &= ~(1 << 28);
outl(reg32, gpiobase + GP_LVL2);
}
static void southbridge_smi_sleep(unsigned int node, smm_state_save_area_t *state_save) static void southbridge_smi_sleep(unsigned int node, smm_state_save_area_t *state_save)
{ {
u8 reg8; u8 reg8;
@@ -372,9 +337,6 @@ static void southbridge_smi_sleep(unsigned int node, smm_state_save_area_t *stat
case 5: case 5:
printk(BIOS_DEBUG, "SMI#: Entering S3 (Suspend-To-RAM)\n"); printk(BIOS_DEBUG, "SMI#: Entering S3 (Suspend-To-RAM)\n");
/* Gate memory reset */
southbridge_gate_memory_reset();
/* Invalidate the cache before going to S3 */ /* Invalidate the cache before going to S3 */
wbinvd(); wbinvd();
break; break;