soc/intel/*/acpi.c: Don't copy structs with memcpy()
				
					
				
			A regular assignment works just as well and also allows type-checking. Change-Id: Id772771f000ba3bad5d4af05f5651c0f0ee43d6d Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/58390 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
		@@ -131,7 +131,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	for (i = 0; i < *entries; i++) {
 | 
			
		||||
		memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t));
 | 
			
		||||
		map[i] = cstate_map[set[i]];
 | 
			
		||||
		map[i].ctype = i + 1;
 | 
			
		||||
	}
 | 
			
		||||
	return map;
 | 
			
		||||
 
 | 
			
		||||
@@ -131,7 +131,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	for (i = 0; i < *entries; i++) {
 | 
			
		||||
		memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t));
 | 
			
		||||
		map[i] = cstate_map[set[i]];
 | 
			
		||||
		map[i].ctype = i + 1;
 | 
			
		||||
	}
 | 
			
		||||
	return map;
 | 
			
		||||
 
 | 
			
		||||
@@ -130,7 +130,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	for (i = 0; i < *entries; i++) {
 | 
			
		||||
		memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t));
 | 
			
		||||
		map[i] = cstate_map[set[i]];
 | 
			
		||||
		map[i].ctype = i + 1;
 | 
			
		||||
	}
 | 
			
		||||
	return map;
 | 
			
		||||
 
 | 
			
		||||
@@ -127,7 +127,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	for (i = 0; i < *entries; i++) {
 | 
			
		||||
		memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t));
 | 
			
		||||
		map[i] = cstate_map[set[i]];
 | 
			
		||||
		map[i].ctype = i + 1;
 | 
			
		||||
	}
 | 
			
		||||
	return map;
 | 
			
		||||
 
 | 
			
		||||
@@ -130,7 +130,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	for (i = 0; i < *entries; i++) {
 | 
			
		||||
		memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t));
 | 
			
		||||
		map[i] = cstate_map[set[i]];
 | 
			
		||||
		map[i].ctype = i + 1;
 | 
			
		||||
	}
 | 
			
		||||
	return map;
 | 
			
		||||
 
 | 
			
		||||
@@ -130,7 +130,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	for (i = 0; i < *entries; i++) {
 | 
			
		||||
		memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t));
 | 
			
		||||
		map[i] = cstate_map[set[i]];
 | 
			
		||||
		map[i].ctype = i + 1;
 | 
			
		||||
	}
 | 
			
		||||
	return map;
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user