sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libpayload: Disable some buggy debugging code

Browse Source 
This disables some debugging code in the OHCI USB driver which causes
reboots under rare circumstances.

Change-Id: Ic274c162846137ee00638ffbc59ccf1d8130586f
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: http://review.coreboot.org/1074
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
Nico Huber
2012-05-21 14:38:08 +02:00
committed by Patrick Georgi
parent e28a61550c
commit 14f61424d0
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
payloads/libpayload/drivers/usb/ohci.c
View File

@@ -214,6 +214,11 @@ wait_for_ed(usbdev_t *dev, ed_t *head)
mdelay(1); mdelay(1);
} }
mdelay(5); mdelay(5);
#if 0
/* XXX: The following debugging code may follow invalid lists and
* cause a reboot.
*/
#ifdef USB_DEBUG
if (OHCI_INST(dev->controller)->opreg->HcInterruptStatus & WritebackDoneHead) { if (OHCI_INST(dev->controller)->opreg->HcInterruptStatus & WritebackDoneHead) {
debug("done queue:\n"); debug("done queue:\n");
debug("%x, %x\n", OHCI_INST(dev->controller)->hcca->HccaDoneHead, phys_to_virt(OHCI_INST(dev->controller)->hcca->HccaDoneHead)); debug("%x, %x\n", OHCI_INST(dev->controller)->hcca->HccaDoneHead, phys_to_virt(OHCI_INST(dev->controller)->hcca->HccaDoneHead));
@@ -236,6 +241,8 @@ wait_for_ed(usbdev_t *dev, ed_t *head)
} }
OHCI_INST(dev->controller)->opreg->HcInterruptStatus &= ~WritebackDoneHead; OHCI_INST(dev->controller)->opreg->HcInterruptStatus &= ~WritebackDoneHead;
} }
#endif
#endif
if (head->head_pointer & 1) { if (head->head_pointer & 1) {
debug("HALTED!\n"); debug("HALTED!\n");