cpu/intel: Enter romstage without BIST
When entry to romstage is via cpu/intel/car/romstage.c BIST has not been passed down the path for sometime. Change-Id: I345975c53014902269cee21fc393331d33a84dce Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/34908 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
@ -61,7 +61,7 @@ static void romstage_main(unsigned long bist)
|
||||
for (i = 0; i < num_guards; i++)
|
||||
stack_base[i] = stack_guard;
|
||||
|
||||
mainboard_romstage_entry(bist);
|
||||
mainboard_romstage_entry();
|
||||
|
||||
/* Check the stack. */
|
||||
for (i = 0; i < num_guards; i++) {
|
||||
|
@ -141,7 +141,6 @@ struct romstage_params {
|
||||
struct pei_data *pei_data;
|
||||
const void *gpio_map;
|
||||
const struct rcba_config_instruction *rcba_config;
|
||||
unsigned long bist;
|
||||
void (*copy_spd)(struct pei_data *);
|
||||
};
|
||||
void romstage_common(const struct romstage_params *params);
|
||||
|
@ -33,14 +33,10 @@ void romstage_common(const struct romstage_params *params)
|
||||
int boot_mode;
|
||||
int wake_from_s3;
|
||||
|
||||
if (params->bist == 0)
|
||||
enable_lapic();
|
||||
enable_lapic();
|
||||
|
||||
wake_from_s3 = early_pch_init(params->gpio_map, params->rcba_config);
|
||||
|
||||
/* Halt if there was a built in self test failure */
|
||||
report_bist_failure(params->bist);
|
||||
|
||||
/* Perform some early chipset initialization required
|
||||
* before RAM initialization can work
|
||||
*/
|
||||
|
Reference in New Issue
Block a user