sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/guybrush: Fix EC SCI configuration

Browse Source 
This change fixes two problems:
1) We had the enum values for .direction and .level swapped. The naming
is very confusing...
2) ESPI_SYS is not a good event to use for EC SCI. It is a level/low
event that is only cleared by reading the eSPI status register 0x9C.
Cezanne has added a new event source that directly exposes the SCI bit.
This is the correct event source to use for EC SCI.

BUG=b:186045622, b:181139095
TEST=`lpc sci` on EC console and see /proc/interrupts increase by 1

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I764b9ec202376d5124331a320767cbf79371dc07
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52673
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Raul E Rangel
2021-04-26 09:43:36 -06:00
committed by Felix Held
parent f62c49474f
commit 15ddb363d4
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/guybrush/ec.c
View File

@@ -9,10 +9,10 @@
static const struct sci_source espi_sci_sources[] = { static const struct sci_source espi_sci_sources[] = {
{ {
.scimap = SMITYPE_ESPI_SYS, .scimap = SMITYPE_ESPI_SCI_B,
.gpe = EC_SCI_GPI, .gpe = EC_SCI_GPI,
.direction = SMI_SCI_LVL, .direction = SMI_SCI_LVL_HIGH, /* enum smi_sci_lvl */
.level = SMI_SCI_LVL_HIGH .level = SMI_SCI_EDG, /* enum smi_sci_dir */
} }
}; };