sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/cbfstool: Include commonlib/helpers.h in common.h

Browse Source 
This avoids re-declaring common macros like ARRAY_SIZE, MIN, MAX and
ALIGN. Also removes the issues around including both files in any
tool.

Also, fix comparison error in various files by replacing int with
size_t.

Change-Id: I06c763e5dd1bec97e8335499468bbdb016eb28e5
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/14978
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Furquan Shaikh
2016-05-26 14:41:02 -07:00
parent 559e947306
commit 161d2334e8
4 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
util/cbfstool/common.c
View File

@@ -139,7 +139,7 @@ static struct {
uint32_t string_to_arch(const char *arch_string)
{
int i;
size_t i;
uint32_t ret = CBFS_ARCHITECTURE_UNKNOWN;
for (i = 0; i < ARRAY_SIZE(arch_names); i++) {
@@ -154,7 +154,7 @@ uint32_t string_to_arch(const char *arch_string)
const char *arch_to_string(uint32_t a)
{
int i;
size_t i;
const char *ret = NULL;
for (i = 0; i < ARRAY_SIZE(arch_names); i++) {