sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/xeon_sp: Change the return type of get_iio_stack_info()

Browse Source 
The somewhat unrelated return value makes the function harder to
understand and the return type is not consistently used. Use a
different helper function to get the HOB Pci64BitResourceAllocation
data.

Change-Id: I9a03cbb0ebbb48cc052d4c082d359c0087aaeb3e
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47298
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marc Jones <marc@marcjonesconsulting.com>
This commit is contained in:
Arthur Heymans 2020-11-06 12:15:41 +01:00
parent 89e83b76b4
commit 165893b67b
5 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/soc/intel/xeon_sp/chip_common.c
View File

@ -403,6 +403,13 @@ static void assign_stack_resources(struct iiostack_resource *stack_list,
} }
} }
static uint8_t is_pci64bit_alloc(void)
{
const IIO_UDS *hob = get_iio_uds();
return hob->PlatformData.Pci64BitResourceAllocation;
}
static void xeonsp_pci_domain_read_resources(struct device *dev) static void xeonsp_pci_domain_read_resources(struct device *dev)
{ {
struct bus *link; struct bus *link;
@ -425,8 +432,8 @@ static void xeonsp_pci_domain_read_resources(struct device *dev)
xeonsp_pci_dev_iterator(link, xeonsp_reset_pci_op, NULL, NULL); xeonsp_pci_dev_iterator(link, xeonsp_reset_pci_op, NULL, NULL);
struct iiostack_resource stack_info = {0}; struct iiostack_resource stack_info = {0};
uint8_t pci64bit_alloc_flag = get_iiostack_info(&stack_info); get_iiostack_info(&stack_info);
if (!pci64bit_alloc_flag) { if (!is_pci64bit_alloc()) {
/* /*
* Split 32 bit address space between prefetchable and * Split 32 bit address space between prefetchable and
* non-prefetchable windows * non-prefetchable windows

2
src/soc/intel/xeon_sp/cpx/include/soc/soc_util.h
View File

@ -11,7 +11,7 @@ struct iiostack_resource {
STACK_RES res[MAX_SOCKET * MAX_LOGIC_IIO_STACK]; STACK_RES res[MAX_SOCKET * MAX_LOGIC_IIO_STACK];
}; };
uint8_t get_iiostack_info(struct iiostack_resource *info); void get_iiostack_info(struct iiostack_resource *info);
const struct SystemMemoryMapHob *get_system_memory_map(void); const struct SystemMemoryMapHob *get_system_memory_map(void);

4
src/soc/intel/xeon_sp/cpx/soc_util.c
View File

@ -27,7 +27,7 @@ const struct SystemMemoryMapHob *get_system_memory_map(void)
return *memmap_addr; return *memmap_addr;
} }
uint8_t get_iiostack_info(struct iiostack_resource *info) void get_iiostack_info(struct iiostack_resource *info)
{ {
const IIO_UDS *hob = get_iio_uds(); const IIO_UDS *hob = get_iio_uds();
@ -42,8 +42,6 @@ uint8_t get_iiostack_info(struct iiostack_resource *info)
} }
} }
} }
return hob->PlatformData.Pci64BitResourceAllocation;
} }
uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack) uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack)

2
src/soc/intel/xeon_sp/skx/include/soc/soc_util.h
View File

@ -11,7 +11,7 @@ struct iiostack_resource {
STACK_RES res[CONFIG_MAX_SOCKET * MAX_IIO_STACK]; STACK_RES res[CONFIG_MAX_SOCKET * MAX_IIO_STACK];
}; };
uint8_t get_iiostack_info(struct iiostack_resource *info); void get_iiostack_info(struct iiostack_resource *info);
void config_reset_cpl3_csrs(void); void config_reset_cpl3_csrs(void);

4
src/soc/intel/xeon_sp/skx/soc_util.c
View File

@ -55,7 +55,7 @@ const struct SystemMemoryMapHob *get_system_memory_map(void)
return memmap_addr; return memmap_addr;
} }
uint8_t get_iiostack_info(struct iiostack_resource *info) void get_iiostack_info(struct iiostack_resource *info)
{ {
const IIO_UDS *hob = get_iio_uds(); const IIO_UDS *hob = get_iio_uds();
@ -71,8 +71,6 @@ uint8_t get_iiostack_info(struct iiostack_resource *info)
memcpy(&info->res[info->no_of_stacks++], ri, sizeof(STACK_RES)); memcpy(&info->res[info->no_of_stacks++], ri, sizeof(STACK_RES));
} }
} }
return hob->PlatformData.Pci64BitResourceAllocation;
} }
uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack) uint32_t get_socket_stack_busno(uint32_t socket, uint32_t stack)