sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eliminate various issues brought up by scan-build.

Browse Source 
Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4152 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Patrick Georgi
2009-04-21 20:14:31 +00:00
parent 5cda45d5ec
commit 16cdbb244c
8 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/devices/pci_device.c
View File

@@ -10,7 +10,8 @@
* Copyright (C) 2004-2005 Li-Ta Lo <ollie@lanl.gov>
* Copyright (C) 2005-2006 Tyan
* (Written by Yinghai Lu <yhlu@tyan.com> for Tyan)
* Copyright (C) 2005-2007 Stefan Reinauer <stepan@openbios.org>
* Copyright (C) 2005-2009 coresystems GmbH
* (Written by Stefan Reinauer <stepan@coresystems.de> for coresystems GmbH)
*/
/*
@@ -271,7 +272,7 @@ static void pci_get_rom_resource(struct device *dev, unsigned long index)
{
struct resource *resource;
unsigned long value;
resource_t moving, limit;
resource_t moving;
if ((dev->on_mainboard) && (dev->rom_address == 0)) {
//skip it if rom_address is not set in MB Config.lb
@@ -296,8 +297,6 @@ static void pci_get_rom_resource(struct device *dev, unsigned long index)
* - Limit is all of the bits that move plus all of the lower bits.
* See PCI Spec 6.2.5.1 ...
*/
limit = 0;
if (moving) {
resource->size = 1;
resource->align = resource->gran = 0;
@@ -306,7 +305,7 @@ static void pci_get_rom_resource(struct device *dev, unsigned long index)
resource->align += 1;
resource->gran += 1;
}
resource->limit = limit = moving | (resource->size - 1);
resource->limit = moving | (resource->size - 1);
}
if (moving == 0) {