sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/*: Replace use of gfx/generic addr field with display type

Browse Source 
Eliminates the use of a magic number, and the resulting DID entry in the
_DOD method is the same.

TEST=build/boot google/drallion, dump SSDT and verify DID entry is
unchanged.

Change-Id: Ic929cf7ec6849ba398653226bbe46d27b4e3fa81
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80200
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
This commit is contained in:
Matt DeVillier
2024-01-26 16:09:42 -06:00
committed by Felix Singer
parent 32d679e8a4
commit 1810a18415
28 changed files with 32 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/brya/variants/anahera/overridetree.cb
View File

@@ -93,7 +93,7 @@ chip soc/intel/alderlake
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
register "device[0].privacy.enabled" = "1"
register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)"
# DDIB for HDMI
@@ -119,7 +119,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

4
src/mainboard/google/brya/variants/anahera4es/overridetree.cb
View File

@@ -75,7 +75,7 @@ chip soc/intel/alderlake
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
register "device[0].privacy.enabled" = "1"
register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)"
# DDIB for HDMI
@@ -101,7 +101,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/brya/variants/anraggar/overridetree.cb
View File

@@ -193,7 +193,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
# If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB
register "device[1].name" = ""DD01""

2
src/mainboard/google/brya/variants/banshee/overridetree.cb
View File

@@ -100,7 +100,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/brya/variants/brya0/overridetree.cb
View File

@@ -124,7 +124,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
# If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB
register "device[1].name" = ""DD01""

2
src/mainboard/google/brya/variants/crota/overridetree.cb
View File

@@ -113,7 +113,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/brya/variants/dochi/overridetree.cb
View File

@@ -93,7 +93,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/brya/variants/felwinter/overridetree.cb
View File

@@ -99,7 +99,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) is unused for any ports but still enumerated in the kernel, so GFX device is added for TCP0

2
src/mainboard/google/brya/variants/gimble/overridetree.cb
View File

@@ -80,7 +80,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/brya/variants/gimble4es/overridetree.cb
View File

@@ -45,7 +45,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/brya/variants/kano/overridetree.cb
View File

@@ -102,7 +102,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/brya/variants/marasov/overridetree.cb
View File

@@ -147,7 +147,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/brya/variants/mithrax/overridetree.cb
View File

@@ -97,7 +97,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) is unused for any ports but still enumerated in the kernel, so GFX device is added for TCP0

2
src/mainboard/google/brya/variants/omnigul/overridetree.cb
View File

@@ -136,7 +136,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/brya/variants/osiris/overridetree.cb
View File

@@ -76,7 +76,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/brya/variants/primus/overridetree.cb
View File

@@ -88,7 +88,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

4
src/mainboard/google/brya/variants/redrix/overridetree.cb
View File

@@ -108,7 +108,7 @@ chip soc/intel/alderlake
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
register "device[0].privacy.enabled" = "1"
register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)"
# DDIB for HDMI
@@ -134,7 +134,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

4
src/mainboard/google/brya/variants/redrix4es/overridetree.cb
View File

@@ -89,7 +89,7 @@ chip soc/intel/alderlake
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
register "device[0].privacy.enabled" = "1"
register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_H21)"
# DDIB for HDMI
@@ -115,7 +115,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/brya/variants/skolas/overridetree.cb
View File

@@ -123,7 +123,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
# If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB
register "device[1].name" = ""DD01""

2
src/mainboard/google/brya/variants/skolas4es/overridetree.cb
View File

@@ -118,7 +118,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
# If HDMI is not enumerated in the kernel, then no GFX device should be added for DDIB
register "device[1].name" = ""DD01""

2
src/mainboard/google/brya/variants/taeko/overridetree.cb
View File

@@ -143,7 +143,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
# TCP0 (DP-1) for port C0
register "device[1].name" = ""DD01""

2
src/mainboard/google/brya/variants/taeko4es/overridetree.cb
View File

@@ -124,7 +124,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
# TCP0 (DP-1) for port C0
register "device[1].name" = ""DD01""

2
src/mainboard/google/brya/variants/taniks/overridetree.cb
View File

@@ -120,7 +120,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
# TCP0 (DP-1) for port C0
register "device[1].name" = ""DD01""

2
src/mainboard/google/brya/variants/vell/overridetree.cb
View File

@@ -99,7 +99,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
# TCP0 (DP-1) for port C0
register "device[1].name" = ""DD01""

2
src/mainboard/google/brya/variants/volmar/overridetree.cb
View File

@@ -94,7 +94,7 @@ chip soc/intel/alderlake
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
# DDIB for HDMI
register "device[1].name" = ""DD01""
# TCP0 (DP-1) for port C0

2
src/mainboard/google/drallion/variants/drallion/devicetree.cb
View File

@@ -225,7 +225,7 @@ chip soc/intel/cannonlake
register "device[0].name" = ""LCD0""
# Address is set following the ACPI spec section A.3.2
# for an internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
register "device[0].privacy.enabled" = "1"
register "device[0].privacy.detect_function" = ""\\_SB.PCI0.LPCB.EC0.GPVD""
register "device[0].privacy.status_function" = ""\\_SB.PCI0.LPCB.EC0.GPVX""

2
src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb
View File

@@ -185,7 +185,7 @@ chip soc/amd/cezanne
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
register "device[0].privacy.enabled" = "1"
register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_18)"
device generic 0.0 on

2
src/mainboard/google/hatch/variants/jinlon/overridetree.cb
View File

@@ -76,7 +76,7 @@ chip soc/intel/cannonlake
# Use ChromeOS privacy screen HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
register "device[0].type" = "panel"
register "device[0].privacy.enabled" = "1"
register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E0)"
device generic 0 alias eps on end