sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

The resource allocator complained about 0-sized fixed

Browse Source 
resources before actually validating if the resource is
a fixed one.

No harm done, except some confusion of the user (in this case: me).

Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4606 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Patrick Georgi 2009-08-28 12:48:02 +00:00
parent d5f9f0024d
commit 18c585b78a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/devices/device.c
View File

@ -556,14 +556,14 @@ static void constrain_resources(struct device *dev, struct constraints* limits)
/* Constrain limits based on the fixed resources of this device. */ /* Constrain limits based on the fixed resources of this device. */
for (i = 0; i < dev->resources; i++) { for (i = 0; i < dev->resources; i++) {
res = &dev->resource[i]; res = &dev->resource[i];
if (!(res->flags & IORESOURCE_FIXED))
continue;
if (!res->size) { if (!res->size) {
/* It makes no sense to have 0-sized, fixed resources.*/ /* It makes no sense to have 0-sized, fixed resources.*/
printk_err("skipping %s@%lx fixed resource, size=0!\n", printk_err("skipping %s@%lx fixed resource, size=0!\n",
dev_path(dev), res->index); dev_path(dev), res->index);
continue; continue;
} }
if (!(res->flags & IORESOURCE_FIXED))
continue;
/* PREFETCH, MEM, or I/O - skip any others. */ /* PREFETCH, MEM, or I/O - skip any others. */
if ((res->flags & MEM_MASK) == PREF_TYPE) if ((res->flags & MEM_MASK) == PREF_TYPE)