sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

amdfwtool: Compact the parameter transfering

Browse Source 
Remove redundant parameter "debug" from open_process_config().

Change-Id: Ib91a505838d7be4980d6b4f1e95fb8601fbbfd16
Signed-off-by: Zheng Bao <fishbaozi@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81201
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Zheng Bao 2024-03-09 12:38:16 +08:00 committed by Felix Held
parent d22c2c8772
commit 18cf3f7966
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
util/amdfwtool/amdfwtool.c
View File

@ -1469,7 +1469,7 @@ static int set_efs_table(uint8_t soc_id, amd_cb_config *cb_config,
return 0; return 0;
} }
void open_process_config(char *config, amd_cb_config *cb_config, int debug) void open_process_config(char *config, amd_cb_config *cb_config)
{ {
FILE *config_handle; FILE *config_handle;
@ -1490,7 +1490,7 @@ void open_process_config(char *config, amd_cb_config *cb_config, int debug)
} }
/* For debug. */ /* For debug. */
if (debug) { if (cb_config->debug) {
dump_psp_firmwares(amd_psp_fw_table); dump_psp_firmwares(amd_psp_fw_table);
dump_bdt_firmwares(amd_bios_table); dump_bdt_firmwares(amd_bios_table);
} }
@ -1539,7 +1539,7 @@ int main(int argc, char **argv)
memcpy(ctx.amd_bios_table_clean, amd_bios_table, sizeof(amd_bios_table)); memcpy(ctx.amd_bios_table_clean, amd_bios_table, sizeof(amd_bios_table));
} }
open_process_config(cb_config.config, &cb_config, cb_config.debug); open_process_config(cb_config.config, &cb_config);
ctx.rom = malloc(ctx.rom_size); ctx.rom = malloc(ctx.rom_size);
if (!ctx.rom) { if (!ctx.rom) {
@ -1625,8 +1625,7 @@ int main(int argc, char **argv)
memcpy(amd_bios_table, ctx.amd_bios_table_clean, memcpy(amd_bios_table, ctx.amd_bios_table_clean,
sizeof(amd_bios_table)); sizeof(amd_bios_table));
assert_fw_entry(combo_index, MAX_COMBO_ENTRIES, &ctx); assert_fw_entry(combo_index, MAX_COMBO_ENTRIES, &ctx);
open_process_config(cb_config.combo_config[combo_index], &cb_config, open_process_config(cb_config.combo_config[combo_index], &cb_config);
cb_config.debug);
/* In most cases, the address modes are same. */ /* In most cases, the address modes are same. */
if (cb_config.need_ish) if (cb_config.need_ish)