sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86/mp_init.c: Set a bogus initial lapic_id

Browse Source 
This makes it easier to catch errors later if the ap_init code fails to
properly set things up.

Change-Id: I938faf042bfa4fe1fc39e78ab740c9b210bc105c
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69108
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jonathan Zhang <jonzhang@fb.com>
This commit is contained in:
Arthur Heymans
2022-11-01 19:51:13 +01:00
committed by Felix Held
parent 506014f624
commit 1bb9786da3
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/cpu/x86/mp_init.c
View File

@@ -375,9 +375,11 @@ static int allocate_cpu_devices(struct bus *cpu_bus, struct mp_params *p)
/* Build the CPU device path */ /* Build the CPU device path */
cpu_path.type = DEVICE_PATH_APIC; cpu_path.type = DEVICE_PATH_APIC;
/* Assuming linear APIC space allocation. AP will set its own /*
APIC id in the ap_init() path above. */ * Set a bogus apic_id.
cpu_path.apic.apic_id = info->cpu->path.apic.apic_id + i; * AP will set its own APIC id in the ap_init() path above.
*/
cpu_path.apic.apic_id = UINT32_MAX;
/* Allocate the new CPU device structure */ /* Allocate the new CPU device structure */
new = alloc_find_dev(cpu_bus, &cpu_path); new = alloc_find_dev(cpu_bus, &cpu_path);