mmio: Add clrsetbitsXX() API in place of updateX()
This patch removes the recently added update8/16/32/64() API and replaces it with clrsetbits8/16/32/64(). This is more in line with the existing endian-specific clrsetbits_le16/32/64() functions that have been used for this task on some platforms already. Rename clrsetbits_8() to clrsetbits8() to be in line with the new naming. Keep this stuff in <device/mmio.h> and get rid of <mmio.h> again because having both is confusing and we seem to have been standardizing on <device/mmio.h> as the standard arch-independent header that all platforms should include already. Also sync libpayload back up with what we have in coreboot. (I'm the original author of the clrsetbits_le32-definitions so I'm relicensing them to BSD here.) Change-Id: Ie4f7b9fdbdf9e8c0174427b4288f79006d56978b Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/37432 Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
committed by
Patrick Georgi
parent
41fe62b6dc
commit
1c37157218
@@ -79,11 +79,6 @@
|
||||
#define clrsetbits_le16(addr, clear, set) __clrsetbits(le, 16, addr, clear, set)
|
||||
#define clrsetbits_be16(addr, clear, set) __clrsetbits(be, 16, addr, clear, set)
|
||||
|
||||
#define clrsetbits_8(addr, clear, set) \
|
||||
write8(addr, (read8(addr) & ~(clear)) | (set))
|
||||
#define clrbits_8(addr, clear) clrsetbits_8(addr, clear, 0)
|
||||
#define setbits_8(addr, set) setbits_8(addr, 0, set)
|
||||
|
||||
#ifndef __ROMCC__
|
||||
/* be16dec/be32dec/be64dec/le16dec/le32dec/le64dec family of functions. */
|
||||
#define DEFINE_ENDIAN_DEC(endian, width) \
|
||||
|
||||
Reference in New Issue
Block a user