From 1dd8991fef5e4c5174cdcdd1e1e44c5d1fa9ed0e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C4=99drzej=20Ciupis?= Date: Fri, 2 Aug 2024 12:56:30 +0200 Subject: [PATCH] soc/intel/common: fix CrashLog size in legacy mode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Intel's PMC CrashLog size in legacy mode is expressed in DWORDs and therefore needs to be explicitly recalculated to bytes. BUG=None TEST=Built and checked the size in logs Change-Id: I2678d537439c24fbd10aa3ceffee63c9a849d28b Signed-off-by: Jędrzej Ciupis Reviewed-on: https://review.coreboot.org/c/coreboot/+/83883 Tested-by: build bot (Jenkins) Reviewed-by: Jakub Czapiga --- src/soc/intel/common/block/crashlog/crashlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/common/block/crashlog/crashlog.c b/src/soc/intel/common/block/crashlog/crashlog.c index 041c8bf1af..007b469ba1 100644 --- a/src/soc/intel/common/block/crashlog/crashlog.c +++ b/src/soc/intel/common/block/crashlog/crashlog.c @@ -379,7 +379,7 @@ void __weak cl_get_pmc_sram_data(cl_node_t *head) return; } pmc_crashLog_size = (discovery_buf.bits.size != 0) ? - discovery_buf.bits.size : 0xC00; + discovery_buf.bits.size * sizeof(u32) : 0xC00; printk(BIOS_DEBUG, "PMC crashLog size in legacy mode : 0x%X\n", pmc_crashLog_size); }