sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax

Browse Source 
Replace `Subtract (a, b)` with `a - b`.

Change-Id: I4f6ffd6bbf6a37e041879e50fe41ce3cc856371f
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60497
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
This commit is contained in:
Felix Singer
2021-12-30 02:09:31 +01:00
parent f94ec24eb9
commit 1eba1968b5
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/drivers/intel/gma/acpi/common.asl
View File

@@ -9,7 +9,7 @@
Store (Match (BRIG, MEQ, Arg0, MTR, Zero, 2), Local0) Store (Match (BRIG, MEQ, Arg0, MTR, Zero, 2), Local0)
If (LEqual (Local0, Ones)) If (LEqual (Local0, Ones))
{ {
Return (Subtract(SizeOf(BRIG), One)) Return (SizeOf(BRIG) - 1)
} }
Return (Local0) Return (Local0)
} }
@@ -56,7 +56,7 @@
Notify (LCD0, 0x86) Notify (LCD0, 0x86)
} Else { } Else {
Store (BRID (XBQC ()), Local0) Store (BRID (XBQC ()), Local0)
If (LNotEqual (Local0, Subtract(SizeOf(BRIG), One))) If (LNotEqual (Local0, SizeOf(BRIG) - 1))
{ {
Increment (Local0) Increment (Local0)
} }

6
src/drivers/intel/gma/acpi/configure_brightness_levels.asl
View File

@@ -121,15 +121,13 @@
/* Local1: loop index (selectable values start at 2 in BRIG) */ /* Local1: loop index (selectable values start at 2 in BRIG) */
Store (2, Local1) Store (2, Local1)
While (LLess (Local1, Subtract (SizeOf (BRIG), 1))) { While (LLess (Local1, SizeOf (BRIG) - 1)) {
/* Local[23]: adjacent values in BRIG */ /* Local[23]: adjacent values in BRIG */
Store (DeRefOf (BRIG[Local1]), Local2) Store (DeRefOf (BRIG[Local1]), Local2)
Store (DeRefOf (BRIG[Add (Local1, 1)]), Local3) Store (DeRefOf (BRIG[Add (Local1, 1)]), Local3)
If (LLess (Local0, Local3)) { If (LLess (Local0, Local3)) {
If (LOr (LLess (Local0, Local2), If (LOr (LLess (Local0, Local2), LLess (Local0 - Local2, Local3 - Local0))) {
LLess (Subtract (Local0, Local2),
Subtract (Local3, Local0)))) {
Return (Local2) Return (Local2)
} Else { } Else {
Return (Local3) Return (Local3)