mb/google/hatch: Allow variants to not necessarily be laptops

In some cases Hatch variants are not laptop form-factors such
as Puff. Ensure that the base configuration does not assume
the form factor and allow variants to elect their intended
use-case.

Note that the issue is that early ec sync needs to be
disabled for EFS2 to function correctly, see commit 6daa8c3ba5
from the FIXME line. The relationship is that desktops do not
have a battery.

BUG=b:152951181
BRANCH=none
TEST=none

Change-Id: I15dc9efa51e9d61297868df287879dfb62909e33
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40252
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Shelley Chen <shchen@google.com>
Reviewed-by: Daniel Kurtz <djkurtz@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Edward O'Callaghan
2020-04-07 12:52:55 +10:00
committed by Edward O'Callaghan
parent ef6eceea56
commit 200f02a518
2 changed files with 25 additions and 4 deletions

View File

@@ -22,10 +22,13 @@ config BOARD_GOOGLE_BASEBOARD_HATCH
select MAINBOARD_HAS_TPM2
select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE
select SOC_INTEL_COMETLAKE
select SYSTEM_TYPE_LAPTOP
select RT8168_GET_MAC_FROM_VPD
select RT8168_SET_LED_MODE
config BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP
select SYSTEM_TYPE_LAPTOP
def_bool n
if BOARD_GOOGLE_BASEBOARD_HATCH
config CHROMEOS
@@ -134,8 +137,13 @@ config VARIANT_DIR
config VBOOT
select HAS_RECOVERY_MRC_CACHE
select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
# FIXME: allow kconfig to select on a subset of boards only
select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_PUFF
select VBOOT_LID_SWITCH
endif # BOARD_GOOGLE_BASEBOARD_HATCH
if BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP
config VBOOT
select VBOOT_EARLY_EC_SYNC
select VBOOT_LID_SWITCH
endif # BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP