sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/meteorlake: Switch to SOC_INTEL_COMMON_DEBUG_CONSENT

Browse Source 
This patch replaces the SoC-specific config option
`SOC_INTEL_METEORLAKE_DEBUG_CONSENT` with the generic
`SOC_INTEL_COMMON_DEBUG_CONSENT`.

Additionally, updates the FSP configuration to use the new generic
config option.

TEST=Able to build and boot google/rex0 without any functional impact
while debugging.

Change-Id: I657d20a38e15eee333a4e45c0c600736148173d4
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83961
Reviewed-by: Dinesh Gehlot <digehlot@google.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Subrata Banik
2024-08-17 18:30:44 +00:00
committed by Felix Held
parent e6f6d2b76c
commit 2142053986
2 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/soc/intel/meteorlake/Kconfig
View File

@@ -357,21 +357,13 @@ config FSP_FD_PATH
depends on FSP_USE_REPO depends on FSP_USE_REPO
default "3rdparty/fsp/MeteorLakeFspBinPkg/Fsp.fd" default "3rdparty/fsp/MeteorLakeFspBinPkg/Fsp.fd"
config SOC_INTEL_METEORLAKE_DEBUG_CONSENT # Override platform debug consent value:
int "Debug Consent for MTL" # 0:Disabled, 2:Enabled Trace Active, 4:Enabled Trace Ready,
# USB DBC is more common for developers so make this default to 6 if # 6:Enable Trace Power-Off, 7:Manual
# SOC_INTEL_DEBUG_CONSENT=y config SOC_INTEL_COMMON_DEBUG_CONSENT
int
default 6 if SOC_INTEL_DEBUG_CONSENT default 6 if SOC_INTEL_DEBUG_CONSENT
default 2 if SOC_INTEL_COMMON_BLOCK_TRACEHUB default 2 if SOC_INTEL_COMMON_BLOCK_TRACEHUB
default 0
help
This is to control debug interface on SOC.
Setting non-zero value will allow to use DBC or DCI to debug SOC.
PlatformDebugConsent in FspmUpd.h has the details.
Desired platform debug type are
0:Disabled, 2:Enabled Trace Active, 4:Enabled Trace Ready,
6:Enable Trace Power-Off, 7:Manual
config DATA_BUS_WIDTH config DATA_BUS_WIDTH
int int

2
src/soc/intel/meteorlake/romstage/fsp_params.c
View File

@@ -364,7 +364,7 @@ static void fill_fspm_trace_params(FSP_M_CONFIG *m_cfg,
const struct soc_intel_meteorlake_config *config) const struct soc_intel_meteorlake_config *config)
{ {
/* Set debug probe type */ /* Set debug probe type */
m_cfg->PlatformDebugOption = CONFIG_SOC_INTEL_METEORLAKE_DEBUG_CONSENT; m_cfg->PlatformDebugOption = CONFIG_SOC_INTEL_COMMON_DEBUG_CONSENT;
/* CrashLog config */ /* CrashLog config */
if (CONFIG(SOC_INTEL_CRASHLOG)) { if (CONFIG(SOC_INTEL_CRASHLOG)) {