sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/fast_spi/Makefile: Fix exit of 16mib-check recipe

Browse Source 
Currently, if everything worked fine, `$fail` will be unset, leading
to the following `if` statement:

    if [ -eq 1 ]

Resulting in the error message:

    /bin/sh: line 9: [: -eq: unary operator expected

Fix this by removing the whole `if`, we can just use `exit`.

Change-Id: I1bc7508d2a45a2bec07ef46b9c5d9d0b740fbc74
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51324
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Nico Huber
2021-03-07 13:09:47 +01:00
parent 76dab5f98f
commit 21666e4611
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/intel/common/block/fast_spi/Makefile.inc
View File

@@ -44,7 +44,7 @@ $(call add_intermediate, check-fmap-16mib-crossing, $(obj)/fmap_config.h)
end=$$((start+size-1)); \ end=$$((start+size-1)); \
if [ $$start -lt 16777216 ] && [ $$end -ge 16777216 ]; then echo "ERROR:" $$x "crosses 16MiB boundary"; fail=1; break; fi; \ if [ $$start -lt 16777216 ] && [ $$end -ge 16777216 ]; then echo "ERROR:" $$x "crosses 16MiB boundary"; fail=1; break; fi; \
done; \ done; \
if [ $$fail -eq 1 ]; then false; fi exit $$fail
CBFSTOOL_ADD_CMD_OPTIONS += --ext-win-base $(CONFIG_EXT_BIOS_WIN_BASE) --ext-win-size $(CONFIG_EXT_BIOS_WIN_SIZE) CBFSTOOL_ADD_CMD_OPTIONS += --ext-win-base $(CONFIG_EXT_BIOS_WIN_BASE) --ext-win-size $(CONFIG_EXT_BIOS_WIN_SIZE)