sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/lib/dimm_info_util.c: Add methods to convert from SMBIOS to SPD

Browse Source 
AMD AGESA returns DIMM info in SMBIOS format. dimm_info expects the data
in SPD format. These methods will be used to update amd_late_init.c so
it sets the correct values.

BUG=b:65403853
TEST=Built and booted grunt. Methods are not called in this commit. So
they were tested with the later commit by verifying the output of
dmidecode.

Change-Id: Id9fa98e9aad83dfd0a86f45e18b3c312665dce9b
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-on: https://review.coreboot.org/25412
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Raul E Rangel
2018-03-29 10:18:14 -06:00
committed by Aaron Durbin
parent 73cd7cf0f2
commit 21db6cccd4
4 changed files with 149 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
src/include/dimm_info_util.h Normal file
View File

@@ -0,0 +1,47 @@
/*
* This file is part of the coreboot project.
*
* Copyright 2018 Google LLC.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License version
* 2 as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#ifndef _DIMM_INFO_UTIL_H_
#define _DIMM_INFO_UTIL_H_
#include <smbios.h>
#include <stdint.h>
/**
* Convert the SMBIOS bit widths into an SPD encoded width.
*
* Use this when setting dimm_info.bus_width if the raw SPD values are not
* available.
*/
uint8_t smbios_bus_width_to_spd_width(uint16_t total_width,
uint16_t data_width);
/**
* Convert the SMBIOS size values into the total number of MiB.
*
* Use this when setting dimm_info.dimm_size.
*/
uint32_t smbios_memory_size_to_mib(uint16_t memory_size,
uint32_t extended_size);
/**
* Convert the SMBIOS form factor to the SPD module type.
*
* Use this when setting dimm_info.mod_type.
*/
uint8_t
smbios_form_factor_to_spd_mod_type(smbios_memory_form_factor form_factor);
#endif

4
src/include/spd.h
View File

@@ -289,7 +289,7 @@ enum spd_memory_type {
#define RC62 62
#define RC63 63
/* Byte 20: DIMM type information */
/* Byte 3: Module type information */
#define SPD_UNDEFINED 0x00
#define SPD_RDIMM 0x01
#define SPD_UDIMM 0x02
@@ -300,4 +300,6 @@ enum spd_memory_type {
#define SPD_MINI_RDIMM 0x10
#define SPD_MINI_UDIMM 0x20
#define SPD_ECC_8BIT (1<<3)
#endif