soc/intel/skylake: Avoid TOL_1V8 being set for GPP_F4 ~ GPP_F11

According to doc 609208, bit 25 TOL_1V8 in GPP_F4 ~ GPP_F11 DW1
should be clear to prevent unexpected I2C behaviors.

BUG=b:124269499
TEST=boot on nami and check bit 25 TOL_1V8 is clear

Change-Id: I419ef3e89104ad3611e96bbe23a582504b45be0c
Signed-off-by: Kane Chen <kane.chen@intel.com>
Reviewed-on: https://review.coreboot.org/c/31368
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Kane Chen
2019-02-12 21:14:13 +08:00
committed by Patrick Georgi
parent 1ac2ad0fbe
commit 223ddc298a
3 changed files with 34 additions and 0 deletions

View File

@@ -273,6 +273,9 @@ static void gpio_configure_pad(const struct pad_config *cfg)
soc_pad_conf &= mask[i]; soc_pad_conf &= mask[i];
soc_pad_conf |= pad_conf & ~mask[i]; soc_pad_conf |= pad_conf & ~mask[i];
/* Patch GPIO settings for SoC specifically */
soc_pad_conf = soc_gpio_pad_config_fixup(cfg, i, soc_pad_conf);
if (IS_ENABLED(CONFIG_DEBUG_GPIO)) if (IS_ENABLED(CONFIG_DEBUG_GPIO))
printk(BIOS_DEBUG, printk(BIOS_DEBUG,
"gpio_padcfg [0x%02x, %02zd] DW%d [0x%08x : 0x%08x" "gpio_padcfg [0x%02x, %02zd] DW%d [0x%08x : 0x%08x"
@@ -571,3 +574,9 @@ const char *gpio_acpi_path(gpio_t gpio_num)
const struct pad_community *comm = gpio_get_community(gpio_num); const struct pad_community *comm = gpio_get_community(gpio_num);
return comm->acpi_path; return comm->acpi_path;
} }
uint32_t __weak soc_gpio_pad_config_fixup(const struct pad_config *cfg,
int dw_reg, uint32_t reg_val)
{
return reg_val;
}

View File

@@ -197,5 +197,15 @@ void gpio_route_gpe(uint8_t gpe0b, uint8_t gpe0c, uint8_t gpe0d);
*/ */
uint8_t gpio_get_pad_portid(const gpio_t pad); uint8_t gpio_get_pad_portid(const gpio_t pad);
/*
* Function to patch GPIO settings for SoC specifically
* cfg = pad config contains pad number and reg value.
* dw_reg = pad config dword number.
* reg_val = the reg value need to be patched.
* Returns gpio setting patched for SoC specifically
*/
uint32_t soc_gpio_pad_config_fixup(const struct pad_config *cfg,
int dw_reg, uint32_t reg_val);
#endif #endif
#endif /* _SOC_INTELBLOCKS_GPIO_H_ */ #endif /* _SOC_INTELBLOCKS_GPIO_H_ */

View File

@@ -168,3 +168,18 @@ const struct pmc_to_gpio_route *soc_pmc_gpio_routes(size_t *num)
*num = ARRAY_SIZE(routes); *num = ARRAY_SIZE(routes);
return routes; return routes;
} }
uint32_t soc_gpio_pad_config_fixup(const struct pad_config *cfg,
int dw_reg, uint32_t reg_val)
{
if (IS_ENABLED(CONFIG_SKYLAKE_SOC_PCH_H))
return reg_val;
/*
* For U/Y series, clear PAD_CFG1_TOL_1V8 in GPP_F4
* ~ GPP_F11.
*/
if (cfg->pad >= GPP_F4 && cfg->pad <= GPP_F11 && dw_reg == 1)
reg_val = reg_val & ~(PAD_CFG1_TOL_1V8);
return reg_val;
}