sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/jasperlake: Update pch_hda.asl to ASL2.0 syntax

Browse Source 
This change updates pch_hda.asl to use ASL2.0 syntax. This
increases the readability of the ASL code.

TEST=Verified using --timeless option to abuild that the resulting
coreboot.rom is same as without the ASL2.0 syntax changes for wdoo.

Change-Id: I8e965560518decbfafabe9ac06066d28d59240d0
Signed-off-by: V Sowmya <v.sowmya@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41863
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
This commit is contained in:
V Sowmya
2020-05-28 22:31:19 +05:30
committed by Patrick Georgi
parent be63cf46e5
commit 2267158776
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/soc/intel/jasperlake/acpi/pch_hda.asl
View File

@@ -26,19 +26,17 @@ Device (HDAS)
*/ */
Method (_DSM, 4) Method (_DSM, 4)
{ {
If (LEqual (Arg0, ^UUID)) { If (Arg0 == ^UUID) {
/* /*
* Function 0: Function Support Query * Function 0: Function Support Query
* Returns a bitmask of functions supported. * Returns a bitmask of functions supported.
*/ */
If (LEqual (Arg2, Zero)) { If (Arg2 == Zero) {
/* /*
* NHLT Query only supported for revision 1 and * NHLT Query only supported for revision 1 and
* if NHLT address and length are set in NVS. * if NHLT address and length are set in NVS.
*/ */
If (LAnd (LEqual (Arg1, One), If ((Arg1 == One) && ((NHLA != Zero) && (NHLL != Zero))) {
LAnd (LNotEqual (NHLA, Zero),
LNotEqual (NHLL, Zero)))) {
Return (Buffer (One) { 0x03 }) Return (Buffer (One) { 0x03 })
} Else { } Else {
Return (Buffer (One) { 0x01 }) Return (Buffer (One) { 0x01 })
@@ -52,14 +50,14 @@ Device (HDAS)
* *
* Returns a pointer to NHLT table in memory. * Returns a pointer to NHLT table in memory.
*/ */
If (LEqual (Arg2, One)) { If (Arg2 == One) {
CreateQWordField (NBUF, ^NHLT._MIN, NBAS) CreateQWordField (NBUF, ^NHLT._MIN, NBAS)
CreateQWordField (NBUF, ^NHLT._MAX, NMAS) CreateQWordField (NBUF, ^NHLT._MAX, NMAS)
CreateQWordField (NBUF, ^NHLT._LEN, NLEN) CreateQWordField (NBUF, ^NHLT._LEN, NLEN)
Store (NHLA, NBAS) NBAS = NHLA
Store (NHLA, NMAS) NMAS = NHLA
Store (NHLL, NLEN) NLEN = NHLL
Return (NBUF) Return (NBUF)
} }