sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/fsp1_1: Drop duplicated "ERROR" in log messages

Browse Source 
Change-Id: I25f56a6f3ca1814666929e91400f52b75a5d607d
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61630
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Elyes HAOUAS
2022-02-04 19:44:16 +01:00
committed by Felix Held
parent c168f115e4
commit 22ad8f2508
2 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/drivers/intel/fsp1_1/raminit.c
View File

@@ -193,8 +193,7 @@ void raminit(struct romstage_params *params)
/* Verify all the HOBs are present */ /* Verify all the HOBs are present */
if (fsp_verification_failure) if (fsp_verification_failure)
printk(BIOS_ERR, printk(BIOS_ERR, "Missing one or more required FSP HOBs!\n");
"ERROR - Missing one or more required FSP HOBs!\n");
/* Display the HOBs */ /* Display the HOBs */
if (CONFIG(DISPLAY_HOBS)) if (CONFIG(DISPLAY_HOBS))
@@ -209,8 +208,7 @@ void raminit(struct romstage_params *params)
if ((fsp_memory != NULL) && (cbmem_root != NULL) && if ((fsp_memory != NULL) && (cbmem_root != NULL) &&
(cbmem_root->PhysicalStart <= fsp_memory->PhysicalStart)) { (cbmem_root->PhysicalStart <= fsp_memory->PhysicalStart)) {
fsp_verification_failure = 1; fsp_verification_failure = 1;
printk(BIOS_ERR, printk(BIOS_ERR, "FSP reserved memory above CBMEM root!\n");
"ERROR - FSP reserved memory above CBMEM root!\n");
} }
/* Verify that the FSP memory was properly reserved */ /* Verify that the FSP memory was properly reserved */
@@ -218,7 +216,7 @@ void raminit(struct romstage_params *params)
(fsp_memory->PhysicalStart != (fsp_memory->PhysicalStart !=
(unsigned int)fsp_reserved_memory_area))) { (unsigned int)fsp_reserved_memory_area))) {
fsp_verification_failure = 1; fsp_verification_failure = 1;
printk(BIOS_ERR, "ERROR - Reserving FSP memory area!\n"); printk(BIOS_ERR, "Reserving FSP memory area!\n");
if (CONFIG(HAVE_SMI_HANDLER) && cbmem_root != NULL) { if (CONFIG(HAVE_SMI_HANDLER) && cbmem_root != NULL) {
size_t delta_bytes = smm_base size_t delta_bytes = smm_base

5
src/drivers/intel/fsp1_1/ramstage.c
View File

@@ -20,7 +20,7 @@ static void display_hob_info(FSP_INFO_HEADER *fsp_info_header)
/* Verify the HOBs */ /* Verify the HOBs */
if (hob_list_ptr == NULL) { if (hob_list_ptr == NULL) {
printk(BIOS_ERR, "ERROR - HOB pointer is NULL!\n"); printk(BIOS_ERR, "HOB pointer is NULL!\n");
return; return;
} }
@@ -41,8 +41,7 @@ static void display_hob_info(FSP_INFO_HEADER *fsp_info_header)
!get_next_guid_hob(&graphics_info_guid, hob_list_ptr) && !get_next_guid_hob(&graphics_info_guid, hob_list_ptr) &&
CONFIG(DISPLAY_HOBS)) { CONFIG(DISPLAY_HOBS)) {
printk(BIOS_ERR, "7.5: EFI_PEI_GRAPHICS_INFO_HOB missing!\n"); printk(BIOS_ERR, "7.5: EFI_PEI_GRAPHICS_INFO_HOB missing!\n");
printk(BIOS_ERR, printk(BIOS_ERR, "Missing one or more required FSP HOBs!\n");
"ERROR - Missing one or more required FSP HOBs!\n");
} }
} }