sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/include: Move storage class to beginning of declaration

Browse Source 
Fix the following warning detected by checkpatch.pl:

WARNING: storage class should be at the beginning of the declaration

The following storage class attribute is not detected by checkpatch.py:

	static cbmem_init_hook_t init_fn_ ## _ptr_ __attribute__((used,
\
	section(".rodata.cbmem_init_hooks"))) = init_fn_;

The following lines generates a false positive:

(pound)define STATIC static
src/include/cpu/amd/common/cbtypes.h:60: WARNING: storage class should
be at the beginning of the declaration

typedef asmlinkage void (*smm_handler_t)(void *);
src/include/cpu/x86/smm.h:514: WARNING: storage class should be at the
beginning of the declaration

(pound)define MAYBE_STATIC static
src/include/stddef.h:34: WARNING: storage class should be at the
beginning of the declaration

TEST=Build and run on Galileo Gen2

Change-Id: Ie087d38e6171b549b90e0b831050ac44746a1e14
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18657
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Lee Leahy 2017-03-07 15:47:44 -08:00
parent 746d4afbed
commit 22c28e0f6a
6 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/include/bootblock_common.h
View File

@ -33,7 +33,7 @@ void bootblock_soc_init(void);
/* /*
* C code entry point for the boot block. * C code entry point for the boot block.
*/ */
void asmlinkage bootblock_c_entry(uint64_t base_timestamp); asmlinkage void bootblock_c_entry(uint64_t base_timestamp);
/* /*
* This is a the same as the bootblock main(), with the difference that it does * This is a the same as the bootblock main(), with the difference that it does
@ -43,6 +43,6 @@ void asmlinkage bootblock_c_entry(uint64_t base_timestamp);
* This function assumes that the timer has already been initialized, so it * This function assumes that the timer has already been initialized, so it
* does not call init_timer(). * does not call init_timer().
*/ */
void asmlinkage bootblock_main_with_timestamp(uint64_t base_timestamp); asmlinkage void bootblock_main_with_timestamp(uint64_t base_timestamp);
#endif /* __BOOTBLOCK_COMMON_H */ #endif /* __BOOTBLOCK_COMMON_H */

36
src/include/cbmem.h
View File

@ -112,36 +112,36 @@ void cbmem_list(void);
void cbmem_add_records_to_cbtable(struct lb_header *header); void cbmem_add_records_to_cbtable(struct lb_header *header);
#if ENV_RAMSTAGE #if ENV_RAMSTAGE
#define ROMSTAGE_CBMEM_INIT_HOOK(init_fn_) static cbmem_init_hook_t \ #define ROMSTAGE_CBMEM_INIT_HOOK(init_fn_) __attribute__((unused)) \
init_fn_ ## _unused_ __attribute__((unused)) = init_fn_; static cbmem_init_hook_t init_fn_ ## _unused_ = init_fn_;
#define RAMSTAGE_CBMEM_INIT_HOOK(init_fn_) \ #define RAMSTAGE_CBMEM_INIT_HOOK(init_fn_) \
static cbmem_init_hook_t init_fn_ ## _ptr_ __attribute__((used, \ static cbmem_init_hook_t init_fn_ ## _ptr_ __attribute__((used, \
section(".rodata.cbmem_init_hooks"))) = init_fn_; section(".rodata.cbmem_init_hooks"))) = init_fn_;
#define POSTCAR_CBMEM_INIT_HOOK(init_fn_) static cbmem_init_hook_t \ #define POSTCAR_CBMEM_INIT_HOOK(init_fn_) __attribute__((unused)) \
init_fn_ ## _unused2_ __attribute__((unused)) = init_fn_; static cbmem_init_hook_t init_fn_ ## _unused2_ = init_fn_;
#elif ENV_ROMSTAGE #elif ENV_ROMSTAGE
#define ROMSTAGE_CBMEM_INIT_HOOK(init_fn_) \ #define ROMSTAGE_CBMEM_INIT_HOOK(init_fn_) \
static cbmem_init_hook_t init_fn_ ## _ptr_ __attribute__((used, \ static cbmem_init_hook_t init_fn_ ## _ptr_ __attribute__((used, \
section(".rodata.cbmem_init_hooks"))) = init_fn_; section(".rodata.cbmem_init_hooks"))) = init_fn_;
#define RAMSTAGE_CBMEM_INIT_HOOK(init_fn_) static cbmem_init_hook_t \ #define RAMSTAGE_CBMEM_INIT_HOOK(init_fn_) __attribute__((unused)) \
init_fn_ ## _unused_ __attribute__((unused)) = init_fn_; static cbmem_init_hook_t init_fn_ ## _unused_ = init_fn_;
#define POSTCAR_CBMEM_INIT_HOOK(init_fn_) static cbmem_init_hook_t \ #define POSTCAR_CBMEM_INIT_HOOK(init_fn_) __attribute__((unused)) \
init_fn_ ## _unused2_ __attribute__((unused)) = init_fn_; static cbmem_init_hook_t init_fn_ ## _unused2_ = init_fn_;
#elif ENV_POSTCAR #elif ENV_POSTCAR
#define ROMSTAGE_CBMEM_INIT_HOOK(init_fn_) static cbmem_init_hook_t \ #define ROMSTAGE_CBMEM_INIT_HOOK(init_fn_) __attribute__((unused)) \
init_fn_ ## _unused2_ __attribute__((unused)) = init_fn_; static cbmem_init_hook_t init_fn_ ## _unused2_ = init_fn_;
#define RAMSTAGE_CBMEM_INIT_HOOK(init_fn_) static cbmem_init_hook_t \ #define RAMSTAGE_CBMEM_INIT_HOOK(init_fn_) __attribute__((unused)) \
init_fn_ ## _unused_ __attribute__((unused)) = init_fn_; static cbmem_init_hook_t init_fn_ ## _unused_ = init_fn_;
#define POSTCAR_CBMEM_INIT_HOOK(init_fn_) \ #define POSTCAR_CBMEM_INIT_HOOK(init_fn_) \
static cbmem_init_hook_t init_fn_ ## _ptr_ __attribute__((used, \ static cbmem_init_hook_t init_fn_ ## _ptr_ __attribute__((used, \
section(".rodata.cbmem_init_hooks"))) = init_fn_; section(".rodata.cbmem_init_hooks"))) = init_fn_;
#else #else
#define ROMSTAGE_CBMEM_INIT_HOOK(init_fn_) static cbmem_init_hook_t \ #define ROMSTAGE_CBMEM_INIT_HOOK(init_fn_) __attribute__((unused)) \
init_fn_ ## _unused_ __attribute__((unused)) = init_fn_; static cbmem_init_hook_t init_fn_ ## _unused_ = init_fn_;
#define RAMSTAGE_CBMEM_INIT_HOOK(init_fn_) static cbmem_init_hook_t \ #define RAMSTAGE_CBMEM_INIT_HOOK(init_fn_) __attribute__((unused)) \
init_fn_ ## _unused2_ __attribute__((unused)) = init_fn_; static cbmem_init_hook_t init_fn_ ## _unused2_ = init_fn_;
#define POSTCAR_CBMEM_INIT_HOOK(init_fn_) static cbmem_init_hook_t \ #define POSTCAR_CBMEM_INIT_HOOK(init_fn_) __attribute__((unused)) \
init_fn_ ## _unused3_ __attribute__((unused)) = init_fn_; static cbmem_init_hook_t init_fn_ ## _unused3_ = init_fn_;
#endif /* ENV_RAMSTAGE */ #endif /* ENV_RAMSTAGE */

2
src/include/cpu/cpu.h
View File

@ -7,7 +7,7 @@
void cpu_initialize(unsigned int cpu_index); void cpu_initialize(unsigned int cpu_index);
struct bus; struct bus;
void initialize_cpus(struct bus *cpu_bus); void initialize_cpus(struct bus *cpu_bus);
void asmlinkage secondary_cpu_init(unsigned int cpu_index); asmlinkage void secondary_cpu_init(unsigned int cpu_index);
int cpu_phys_address_size(void); int cpu_phys_address_size(void);
#define __cpu_driver __attribute__ ((used, __section__(".rodata.cpu_driver"))) #define __cpu_driver __attribute__ ((used, __section__(".rodata.cpu_driver")))

2
src/include/cpu/intel/romstage.h
View File

@ -27,6 +27,6 @@ void *setup_stack_and_mtrrs(void);
asmlinkage void *romstage_main(unsigned long bist); asmlinkage void *romstage_main(unsigned long bist);
/* romstage_after_car() is the C function called after cache-as-ram has /* romstage_after_car() is the C function called after cache-as-ram has
* been torn down. It is responsible for loading the ramstage. */ * been torn down. It is responsible for loading the ramstage. */
void asmlinkage romstage_after_car(void); asmlinkage void romstage_after_car(void);
#endif /* _CPU_INTEL_ROMSTAGE_H */ #endif /* _CPU_INTEL_ROMSTAGE_H */

2
src/include/cpu/x86/smm.h
View File

@ -517,7 +517,7 @@ typedef asmlinkage void (*smm_handler_t)(void *);
/* SMM Runtime helpers. */ /* SMM Runtime helpers. */
/* Entry point for SMM modules. */ /* Entry point for SMM modules. */
void asmlinkage smm_handler_start(void *params); asmlinkage void smm_handler_start(void *params);
/* Retrieve SMM save state for a given CPU. WARNING: This does not take into /* Retrieve SMM save state for a given CPU. WARNING: This does not take into
* account CPUs which are configured to not save their state to RAM. */ * account CPUs which are configured to not save their state to RAM. */

2
src/include/thread.h
View File

@ -65,7 +65,7 @@ static inline void thread_init_cpu_info_non_bsp(struct cpu_info *ci)
} }
/* Architecture specific thread functions. */ /* Architecture specific thread functions. */
void asmlinkage switch_to_thread(uintptr_t new_stack, uintptr_t *saved_stack); asmlinkage void switch_to_thread(uintptr_t new_stack, uintptr_t *saved_stack);
/* Set up the stack frame for a new thread so that a switch_to_thread() call /* Set up the stack frame for a new thread so that a switch_to_thread() call
* will enter the thread_entry() function with arg as a parameter. The * will enter the thread_entry() function with arg as a parameter. The
* saved_stack field in the struct thread needs to be updated accordingly. */ * saved_stack field in the struct thread needs to be updated accordingly. */