sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "drivers/spi/spi_flash: don't allocate unbounded stack memory"

Browse Source 
This reverts commit c5ee35ff86.

Reason for revert: breaks boards, uncertain if it _really_ works.

Change-Id: I9ba2ba877b9a391306f89295c0c1d0e2d011c5ea
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://review.coreboot.org/28338
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Jean Lucas <jean@4ray.co>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Patrick Georgi
2018-08-24 22:45:50 +00:00
parent 16ebc9831f
commit 24151963f3
1 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/drivers/spi/spi_flash.c
View File

@ -82,29 +82,24 @@ static int spi_flash_cmd_read(const struct spi_slave *spi, const u8 *cmd,
return ret; return ret;
} }
/* TODO: This code is quite possibly broken and overflowing stacks. Fix ASAP! */
#pragma GCC diagnostic push
#if defined(__GNUC__) && !defined(__clang__)
#pragma GCC diagnostic ignored "-Wstack-usage="
#endif
int spi_flash_cmd_write(const struct spi_slave *spi, const u8 *cmd, int spi_flash_cmd_write(const struct spi_slave *spi, const u8 *cmd,
size_t cmd_len, const void *data, size_t data_len) size_t cmd_len, const void *data, size_t data_len)
{ {
int ret = 1; int ret;
struct spi_op vectors[] = { u8 buff[cmd_len + data_len];
[0] = { .dout = cmd, .bytesout = cmd_len, memcpy(buff, cmd, cmd_len);
.din = NULL, .bytesin = 0, }, memcpy(buff + cmd_len, data, data_len);
[1] = { .dout = data, .bytesout = data_len,
.din = NULL, .bytesin = 0, }
};
size_t count = ARRAY_SIZE(vectors);
if (spi_claim_bus(spi))
return ret;
if (spi_xfer_vector(spi, vectors, count) == 0)
ret = 0;
ret = do_spi_flash_cmd(spi, buff, cmd_len + data_len, NULL, 0);
if (ret) { if (ret) {
printk(BIOS_WARNING, "SF: Failed to send write command (%zu bytes): %d\n", printk(BIOS_WARNING, "SF: Failed to send write command (%zu bytes): %d\n",
data_len, ret); data_len, ret);
} }
spi_release_bus(spi);
return ret; return ret;
} }