sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src: Don't use a #defines like Kconfig symbols

Browse Source 
This is spotted using ./util/lint/kconfig_lint
To work around the issue, rename the prefix from `CONFIG_` to `CONF_`.

Change-Id: Ia31aed366bf768ab167ed5f8595bee8234aac46b
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/31049
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Elyes HAOUAS
2019-01-23 11:36:44 +01:00
committed by Patrick Georgi
parent 9e946079e8
commit 251514d986
10 changed files with 42 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/superio/smsc/lpc47n207/early_serial.c
View File

@ -49,16 +49,16 @@ void try_enabling_LPC47N207_uart(void)
u16 lpc_port;
int i, j;
#define CONFIG_ENABLE 0x55
#define CONFIG_DISABLE 0xaa
#define CONF_ENABLE 0x55
#define CONF_DISABLE 0xaa
for (j = 0; j < ARRAY_SIZE(lpc_ports); j++) {
lpc_port = lpc_ports[j];
/* enable CONFIG mode */
outb(CONFIG_ENABLE, lpc_port);
outb(CONF_ENABLE, lpc_port);
reg_value = inb(lpc_port);
if (reg_value != CONFIG_ENABLE) {
if (reg_value != CONF_ENABLE) {
continue; /* There is no LPC device at this address */
}
@ -94,6 +94,6 @@ void try_enabling_LPC47N207_uart(void)
outb(reg_value, lpc_port + 1);
}
} while (0);
outb(CONFIG_DISABLE, lpc_port);
outb(CONF_DISABLE, lpc_port);
}
}