sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/{baytrail,braswell}: Make use of generic set_subsystem()

Browse Source 
We missed some PCIe root ports with previous cleanup.

Change-Id: I8bf8f8b2ca1836316f84fb7f01820a00d7194d51
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31991
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Kyösti Mälkki 2019-03-20 18:36:37 +02:00 committed by Patrick Georgi
parent 0ea04f5853
commit 25200327d9
2 changed files with 2 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/soc/intel/baytrail/pcie.c
View File

@ -240,18 +240,8 @@ static void byt_pciexp_scan_bridge(struct device *dev)
do_pci_scan_bridge(dev, pciexp_scan_bus); do_pci_scan_bridge(dev, pciexp_scan_bus);
} }
static void pcie_root_set_subsystem(struct device *dev, unsigned vid,
unsigned did)
{
uint32_t didvid = ((did & 0xffff) << 16) | (vid & 0xffff);
if (!didvid)
didvid = pci_read_config32(dev, PCI_VENDOR_ID);
pci_write_config32(dev, 0x94, didvid);
}
static struct pci_operations pcie_root_ops = { static struct pci_operations pcie_root_ops = {
.set_subsystem = &pcie_root_set_subsystem, .set_subsystem = pci_dev_set_subsystem,
}; };
static struct device_operations device_ops = { static struct device_operations device_ops = {

14
src/soc/intel/braswell/pcie.c
View File

@ -160,20 +160,8 @@ static void pcie_enable(struct device *dev)
southcluster_enable_dev(dev); southcluster_enable_dev(dev);
} }
static void pcie_root_set_subsystem(struct device *dev, unsigned int vid,
unsigned int did)
{
printk(BIOS_SPEW, "%s/%s (%s, 0x%04x, 0x%04x)\n",
__FILE__, __func__, dev_name(dev), vid, did);
uint32_t didvid = ((did & 0xffff) << 16) | (vid & 0xffff);
if (!didvid)
didvid = pci_read_config32(dev, PCI_VENDOR_ID);
pci_write_config32(dev, 0x94, didvid);
}
static struct pci_operations pcie_root_ops = { static struct pci_operations pcie_root_ops = {
.set_subsystem = &pcie_root_set_subsystem, .set_subsystem = pci_dev_set_subsystem,
}; };
static struct device_operations device_ops = { static struct device_operations device_ops = {