sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/gru: Move selects from Kconfig.name to Kconfig

Browse Source 
Selects should be done in the Kconfig file instead of Kconfig.name and
not mixed over both files.

Change-Id: Id7f9b598cc9df51ddf664b851172cc96a710c580
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75023
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Singer
2023-05-08 19:42:20 +02:00
committed by Felix Singer
parent cef2ca946e
commit 27a1c924e2
2 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/mainboard/google/gru/Kconfig
View File

@@ -3,6 +3,24 @@
config BOARD_GOOGLE_GRU_COMMON # Umbrella option to be selected by variant boards. config BOARD_GOOGLE_GRU_COMMON # Umbrella option to be selected by variant boards.
def_bool n def_bool n
config BOARD_GOOGLE_KEVIN
select BOARD_GOOGLE_GRU_COMMON
config BOARD_GOOGLE_GRU
select BOARD_GOOGLE_GRU_COMMON
config BOARD_GOOGLE_BOB
select BOARD_GOOGLE_GRU_COMMON
config BOARD_GOOGLE_SCARLET
select BOARD_GOOGLE_GRU_COMMON
config BOARD_GOOGLE_NEFARIO
select BOARD_GOOGLE_GRU_COMMON
config BOARD_GOOGLE_RAINIER
select BOARD_GOOGLE_GRU_COMMON
if BOARD_GOOGLE_GRU_COMMON if BOARD_GOOGLE_GRU_COMMON
# Most Grus have TPM2 but later Kevins don't... decide this in one place for # Most Grus have TPM2 but later Kevins don't... decide this in one place for

6
src/mainboard/google/gru/Kconfig.name
View File

@@ -2,24 +2,18 @@ comment "Gru"
config BOARD_GOOGLE_KEVIN config BOARD_GOOGLE_KEVIN
bool "-> Kevin (Samsung Chromebook Plus)" bool "-> Kevin (Samsung Chromebook Plus)"
select BOARD_GOOGLE_GRU_COMMON
config BOARD_GOOGLE_GRU config BOARD_GOOGLE_GRU
bool "-> Gru" bool "-> Gru"
select BOARD_GOOGLE_GRU_COMMON
config BOARD_GOOGLE_BOB config BOARD_GOOGLE_BOB
bool "-> Bob (Asus Chromebook Flip C101PA)" bool "-> Bob (Asus Chromebook Flip C101PA)"
select BOARD_GOOGLE_GRU_COMMON
config BOARD_GOOGLE_SCARLET config BOARD_GOOGLE_SCARLET
bool "-> Scarlet" bool "-> Scarlet"
select BOARD_GOOGLE_GRU_COMMON
config BOARD_GOOGLE_NEFARIO config BOARD_GOOGLE_NEFARIO
bool "-> Nefario" bool "-> Nefario"
select BOARD_GOOGLE_GRU_COMMON
config BOARD_GOOGLE_RAINIER config BOARD_GOOGLE_RAINIER
bool "-> Rainier" bool "-> Rainier"
select BOARD_GOOGLE_GRU_COMMON