sravan/system76-coreboot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add CONFIG_VGA_ROM_RUN to dbm690t and pistachio, otherwise the

Browse Source 
VGA ROM can not run. After make, run
> ./cbfs/cbfstool ./coreboot.rom add ../vga_bios.rom   pci1002,791f.rom  optionrom
to make the final image with vga bios.

The macro vga_rom_address is out-of-date when CBFS starts play its role. it also should
be eliminated from rs690/chip.h as below. But it will cause building error on other board, which I
cant make test on.

##    Index: src/southbridge/amd/rs690/chip.h
##    ===================================================================
##    --- src/southbridge/amd/rs690/chip.h	(revision 4782)
##    +++ src/southbridge/amd/rs690/chip.h	(working copy)
##    @@ -23,7 +23,6 @@
##     /* Member variables are defined in Config.lb. */
##     struct southbridge_amd_rs690_config
##     {
##    -	u32 vga_rom_address;		/* The location that the VGA rom has been appened. */
##     	u8 gpp_configuration;	/* The configuration of General Purpose Port, A/B/C/D/E. */
##     	u8 port_enable;		/* Which port is enabled? GFX(2,3), GPP(4,5,6,7) */
##     	u8 gfx_dev2_dev3;	/* for GFX Core initialization REFCLK_SEL */
##

Don't apply above patch about rs690/chip.h before every board has been fixed.

Signed-off-by: Zheng Bao <zheng.bao@amd.com>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4783 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Zheng Bao
2009-10-16 07:44:04 +00:00
committed by Zheng Bao
parent 9d37532bc1
commit 289a2f5aad
9 changed files with 10 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/southbridge/amd/rs690/rs690_gfx.c
View File

@@ -77,13 +77,9 @@ static void internal_gfx_pci_dev_init(struct device *dev)
(struct southbridge_amd_rs690_config *)dev->chip_info;
deviceid = pci_read_config16(dev, PCI_DEVICE_ID);
vendorid = pci_read_config16(dev, PCI_VENDOR_ID);
printk_info("internal_gfx_pci_dev_init device=%x, vendor=%x, vga_rom_address=0x%x.\n",
deviceid, vendorid, cfg->vga_rom_address);
printk_info("internal_gfx_pci_dev_init device=%x, vendor=%x.\n",
deviceid, vendorid);
#if 0 /* I think these should be done in Config.lb. Please check it. */
dev->on_mainboard = 1;
dev->rom_address = cfg->vga_rom_address; /* 0xfff00000; */
#endif
pci_dev_init(dev);
/* clk ind */