From 28c669e216c5c16caa09f4c28682d37681717f51 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Sun, 3 Mar 2024 14:05:01 -0700 Subject: [PATCH] 3rdparty: Remove chromeec submodule The chromeec submodule is the largest submodule being pulled into the coreboot tree, at over 400MB. The main branch also contains the majority of these commits, so restricting it to a single branch still fetches over 350MB. Because there is only a single mainboard directory that enables the build of the chromeec codebase by default, most people are fetching this repo for no reason. Based on this, we're going to change the way that the chromeec submodule is used, fetching it the way we currently fetch external payloads. This gives us 2 large advantages: 1) Only builds that actually need the chromeec repo will pull it down. 2) Each board that wants to build the chromeec codebase can use a different commit, unlike submodules which all use the same "current" commit. Signed-off-by: Martin Roth Change-Id: I357c4c9b506dd3817a308232446144ae889bc220 Reviewed-on: https://review.coreboot.org/c/coreboot/+/81024 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier Reviewed-by: Julius Werner Reviewed-by: Angel Pons Reviewed-by: Elyes Haouas Reviewed-by: Felix Singer --- .gitmodules | 3 --- 3rdparty/chromeec | 1 - 2 files changed, 4 deletions(-) delete mode 160000 3rdparty/chromeec diff --git a/.gitmodules b/.gitmodules index f1fbe34a52..eec69fd1ec 100644 --- a/.gitmodules +++ b/.gitmodules @@ -13,9 +13,6 @@ [submodule "arm-trusted-firmware"] path = 3rdparty/arm-trusted-firmware url = https://review.coreboot.org/arm-trusted-firmware.git -[submodule "3rdparty/chromeec"] - path = 3rdparty/chromeec - url = https://review.coreboot.org/chrome-ec.git [submodule "libhwbase"] path = 3rdparty/libhwbase url = https://review.coreboot.org/libhwbase.git diff --git a/3rdparty/chromeec b/3rdparty/chromeec deleted file mode 160000 index e486b388a7..0000000000 --- a/3rdparty/chromeec +++ /dev/null @@ -1 +0,0 @@ -Subproject commit e486b388a73f1e19f3142774d0b3ee166e8f41ff